Fix: Presence Detector Validation Error with Cached Configuration #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Presence Detector Validation Error with Cached Configuration
Problem: When the presence detector plugin loads cached configuration with
start_m=0.0,end_m=0.31, andautomatic_subsweeps=True, the_get_profile_subsweepsfunction creates a subsweep withnum_points=0, which fails validation.Root Cause: In
_get_profile_subsweepsfunction, when the while loop doesn't execute (whencurr_point >= cut_pointinitially),n_points_in_subsweepremains 0, causing the validation error.Solution: Add a check to ensure
n_points_in_subsweepis always at least 1 before creating theSubsweepConfig.Changes:
src/acconeer/exptool/a121/algo/presence/_subsweep_utils.py_get_profile_subsweepsTesting:
python -m acconeer.exptool.app --purge-cache) also resolves the issue as a workaroundImpact: High priority - prevents users from using Presence Detector plugin when cached configuration contains problematic parameters.
Workaround: Users can resolve this issue by purging the cache, but this fix prevents it from occurring in the first place.