Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec refactoring #137

Open
8 tasks
ehannes opened this issue Feb 23, 2018 · 2 comments
Open
8 tasks

Spec refactoring #137

ehannes opened this issue Feb 23, 2018 · 2 comments

Comments

@ehannes
Copy link
Member

ehannes commented Feb 23, 2018

Our specs are not the most pretty ones out there. They need some refactoring.

One goal with this gem is to make it as easy as possible to add new resources. Repositories, Models and Mappers does not include any logic at all. These classes does not need any testing. If we instead focus on testing Repository::Base, Model::Base and Mapper::Base then all we need to test for each new resource is the integration with Fortnox, that it really works. We should therefore:

  • Add gem for test coverage (simplecov)

For the new base gem, see #149:

  • 100% test coverage for Model::Base (and all helper classes)
  • 100% test coverage for Mapper::Base (and all helper classes)
  • 100% test coverage for Repository::Base (and all helper classes)

For this gem:

  • Add pure integration specs (not unit specs)
  • Drop model specs
  • Drop mapper specs
  • Drop repository specs
@d-Pixie
Copy link
Member

d-Pixie commented Mar 7, 2018

We should put this on hold for a bit. #149 will change the spec landscape quite a bit and it might be better if we did the refactoring of the test suite after the split.

@d-Pixie
Copy link
Member

d-Pixie commented Mar 7, 2018

Updated original comment to reflect the split of the specs between this gem and the new base gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants