Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle images that can't be resized better #118

Open
robbevp opened this issue Oct 6, 2020 · 3 comments
Open

Handle images that can't be resized better #118

robbevp opened this issue Oct 6, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@robbevp
Copy link
Member

robbevp commented Oct 6, 2020

If the user uploads an image that cannot be resized, they don't get an error, but the image is also not returned in the serializer.

@robbevp robbevp added the bug Something isn't working label Oct 6, 2020
@robbevp robbevp added this to the later milestone Oct 6, 2020
@chvp
Copy link
Member

chvp commented Jul 10, 2021

Do you have an example of a (valid) image that can't be resized?

@robbevp
Copy link
Member Author

robbevp commented Jul 11, 2021

I don't have the image that caused this error anymore. So I don't know if it was valid (though it must have displayed on the website where I got it from).

@chvp
Copy link
Member

chvp commented Jul 11, 2021

I know there were a few PDFs at some point, but that doesn't make any sense to return in the image field. Unless we find a valid image that is not shown this way, I don't think we should return (a link to) it in the JSON.

@chvp chvp removed this from the later milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants