Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size is passed unsigned #6

Open
ericlaw1979 opened this issue Sep 4, 2020 · 0 comments
Open

Size is passed unsigned #6

ericlaw1979 opened this issue Sep 4, 2020 · 0 comments
Assignees
@acandylevey
Labels
question

Comments

@ericlaw1979
Copy link

Should this

var buffer = new char[BitConverter.ToInt32(lengthBytes, 0)];

be

var buffer = new char[BitConverter.ToUInt32(lengthBytes, 0)];

https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/messaging/native_message_process_host.cc;drc=bb733b33b305d7bb1eb4b6553e470cc3afc5bf51;l=191
@acandylevey acandylevey self-assigned this Sep 8, 2020
Repository owner deleted a comment from Pairs34 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acandylevey acandylevey

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericlaw1979 @acandylevey