All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests. Before raising a pull request, ensure you have raised a corresponding issue and discussed a possible solution with a maintainer. This gives your pull request the highest chance of getting merged quickly.
We use Github Flow, so all code changes happen through pull requests.
- Fork the repo and create a new branch from the
release
branch. - Branches are named as
fix/fix-name
orfeature/feature-name
- Please add tests for your changes. Client-side changes require Cypress/Jest tests while server-side changes require JUnit tests.
- Once you are confident in your code changes, create a pull request in your fork to the release branch in the appsmithorg/appsmith base repository.
- If you've changed any APIs, please call this out in the pull request and ensure backward compatibility.
- Link the issue of the base repository in your Pull request description. Guide
- When you raise a pull request, we automatically run tests on our CI. Please ensure that all the tests are passing for your code change. We will not be able to accept your change if the test suite doesn't pass.
- In order to run the Cypress integration tests, run:
cd app/client
yarn run test
- In order to run the Jest unit tests, run:
cd app/client
yarn run test:unit
-
Ensure that you have Redis running on your local system.
-
Run the command to execute tests
cd app/server
mvn clean package