-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preserve frontmatter when updating changelog #108
fix: preserve frontmatter when updating changelog #108
Conversation
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
fixes absolute-version#106 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Matches based off # Changelog title position rather than new header position Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
I'll have a look at these failing tests |
Thanks! Sorry about the lint settings. Every time I work on this, I'm tempted to replace the format rules with default prettier settings, but I didn't really want to fork it and then go "ok here are all my opinions", you know? :) You may also want to merge in master again - speaking of lint settings, I realised that some of the tests weren't actually running, due to dangling promises. So I updated those with some defaults designed to prevent tests that don't do what is expected. I've enabled the "update branch" button to make this easy. |
To be fair, I think moving to some Default Prettier settings would make sense, at least they are a default set of opinions used across tech 😄 |
Awesome. |
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Could've sworn I had run "fix" before pushing, but hey ho. All done now |
Thanks again! Releasing as 12.0.0 (since I also dropped node 14 and 16) |
Thanks Tim, I'll keep an eye out and integrate 12.0.0 into our pipelines as and when |
fixes: #106