Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve frontmatter when updating changelog #108

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

TimKnight-DWP
Copy link

fixes: #106

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
fixes absolute-version#106

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Matches based off # Changelog title position rather than new header position

Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
@TimKnight-DWP
Copy link
Author

I'll have a look at these failing tests

@TimothyJones
Copy link
Member

Thanks! Sorry about the lint settings. Every time I work on this, I'm tempted to replace the format rules with default prettier settings, but I didn't really want to fork it and then go "ok here are all my opinions", you know? :)

You may also want to merge in master again - speaking of lint settings, I realised that some of the tests weren't actually running, due to dangling promises. So I updated those with some defaults designed to prevent tests that don't do what is expected.

I've enabled the "update branch" button to make this easy.

@TimKnight-DWP
Copy link
Author

To be fair, I think moving to some Default Prettier settings would make sense, at least they are a default set of opinions used across tech 😄

@TimothyJones
Copy link
Member

Good point, prettier has definitely won out. I'm convinced.

I reckon I'll do it after this, #99 and #109 have landed - I don't want to stamp on the toes of people currently in the middle of contributing.

@TimKnight-DWP
Copy link
Author

Awesome.

@TimKnight-DWP
Copy link
Author

Could've sworn I had run "fix" before pushing, but hey ho.

All done now

@TimothyJones TimothyJones enabled auto-merge (squash) October 31, 2023 10:10
@TimothyJones TimothyJones merged commit abdcfe2 into absolute-version:master Oct 31, 2023
4 checks passed
@TimothyJones
Copy link
Member

Thanks again! Releasing as 12.0.0 (since I also dropped node 14 and 16)

@TimKnight-DWP
Copy link
Author

Thanks Tim, I'll keep an eye out and integrate 12.0.0 into our pipelines as and when

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front-matter is removed from CHANGELOG when running commit-and-tag-version
2 participants