Skip to content

Commit ac2c116

Browse files
UdjinM6CryptoCentric
authored andcommitted
Fix a very ancient bug from mid 2015 (dashpay#2021)
Introduced in dashpay@c701839#diff-2e2ff25b7bc057a741bf93c35ae3b624R42 (committed on 10 Jul 2015). Survived all the refactoring for almost 3 years and was revealed by dashpay@525c049#diff-49ff8fea774f647034a130c40d4f3c65R519 (as a part of dashpay#1856) by causing silent crashes on multiple nodes (testnet). v0.12.2.x and earlier branches/versions aren't affected, they simply print meaningless log entry.
1 parent 9a09988 commit ac2c116

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/governance-object.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ bool CGovernanceObject::IsCollateralValid(std::string& strError, bool& fMissingC
540540
// RETRIEVE TRANSACTION IN QUESTION
541541

542542
if(!GetTransaction(nCollateralHash, txCollateral, Params().GetConsensus(), nBlockHash, true)){
543-
strError = strprintf("Can't find collateral tx %s", txCollateral->ToString());
543+
strError = strprintf("Can't find collateral tx %s", nCollateralHash.ToString());
544544
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
545545
return false;
546546
}

0 commit comments

Comments
 (0)