From 1f2d4766582de2388e3a7f16a63ef1670533711e Mon Sep 17 00:00:00 2001 From: abpoth Date: Mon, 28 Aug 2023 13:18:15 -0400 Subject: [PATCH] fixing CI errors with Linux Lint --- src/app/tests/suites/certification/PICS.yaml | 186 ++++++++++-------- .../tests/suites/certification/ci-pics-values | 106 +++++----- 2 files changed, 166 insertions(+), 126 deletions(-) diff --git a/src/app/tests/suites/certification/PICS.yaml b/src/app/tests/suites/certification/PICS.yaml index 6a574dd4690c92..6e0e3e9b2ea712 100644 --- a/src/app/tests/suites/certification/PICS.yaml +++ b/src/app/tests/suites/certification/PICS.yaml @@ -1774,8 +1774,25 @@ PICS: - label: "Can the Dishwasher Alarm attribute changed by physical control at the device?" - id: DISHALM.M.ManuallyControlled + id: DISHALM.S.M.ManuallyControlled + - label: "Does the device support the Inflow alarm?" + id: DISHALM.S.M.InflowAlarmSupported + + - label: "Does the device support the Drain alarm?" + id: DISHALM.S.M.DrainAlarmSupported + + - label: "Does the device support the Door alarm?" + id: DISHALM.S.M.DoorAlarmSupported + + - label: "Does the device support the TempLow alarm?" + id: DISHALM.S.M.TempLowAlarmSupported + + - label: "Does the device support the TempHigh alarm?" + id: DISHALM.S.M.TempHighAlarmSupported + + - label: "Does the device support the WaterLevel alarm?" + id: DISHALM.S.M.WaterLevelAlarmSupported # # server / Commands received # @@ -1790,11 +1807,20 @@ PICS: - label: "Does the device implement the DISHM cluster as a server?" id: DISHM.S + - label: "IDoes the DUT support testing the failed ChangeToMode command?" + id: DISHM.S.M.CAN_TEST_MODE_FAILURE + + # PIXIT + - label: "Id of mode the device will fail to transition to, given its current state" - id: PIXIT.DISHM.CAN_TEST_MODE_FAILURE + id: PIXIT.DISHM.MODE_CHANGE_FAIL + - label: + "Id of mode the device will successfully transition to, given its + current state" + id: PIXIT.DISHM.MODE_CHANGE_OK # # server / features # @@ -2862,7 +2888,7 @@ PICS: id: DRLK.S.Simulate.NotFullyLocked - label: "Does the DUT(server) detect a LockJammed State?" - id: DRLK.S.DetectLockJammed + id: DRLK.S.M.DetectLockJammed # # client / attributes @@ -3610,6 +3636,43 @@ PICS: feature?" id: GRPKEY.S.F00 + # + #server attributes + # + - label: "Does the device implement the GroupKeyMap attribute?" + id: GRPKEY.S.A0000 + + - label: "Does the device implement the GroupTable attribute?" + id: GRPKEY.S.A0001 + + - label: "Does the device implement the MaxGroupsPerFabric attribute?" + id: GRPKEY.S.A0002 + + - label: "Does the device implement the MaxGroupKeysPerFabric attribute?" + id: GRPKEY.S.A0003 + + # + # server commandsGenerated + # + - label: "Does the device implement the KeySetWrite command}?" + id: GRPKEY.S.C00.Rsp + + - label: "Does the device implement the KeySetRead command}?" + id: GRPKEY.S.C01.Rsp + + - label: "Does the device implement the KeySetReadResponse command}?" + id: GRPKEY.S.C02.Rsp + + - label: "Does the device implement the KeySetRemove command}?" + id: GRPKEY.S.C03.Rsp + + - label: "Does the device implement the KeySetReadAllIndices command}?" + id: GRPKEY.S.C04.Rsp + + - label: + "Does the device implement the KeySetReadAllIndicesResponse command}?" + id: GRPKEY.S.C05.Rsp + # # client / attributes # @@ -8702,79 +8765,6 @@ PICS: command?" id: ICDM.C.C00.Rsp - # - #RVC Clean Mode Select - # - #Feature - - label: - "Does the device support depending on an On/Off cluster implemented on - the same DUT?" - id: RVCCLEANMS.S.F00 - - - label: "Does the device support the extended status feature?" - id: RVCCLEANMS.S.F01 - - - label: - "Does the device implementation deprecate the ChangeToMode command?" - id: RVCCLEANMS.S.F02 - - #Server Attributes - - label: "Does the device implement the StartUpMode attribute?" - id: RVCCLEANMS.S.A0004 - - - label: "Does the device implement the OnMode attribute?" - id: RVCCLEANMS.S.A0005 - - #Server Commands recived - - label: "Does the device implement receiving the ChangeToMode command?" - id: RVCCLEANMS.S.C00.Rsp - - - label: - "Does the device implement receiving the ChangeToModeWithStatus - command?" - id: RVCCLEANMS.S.C01.Rsp - - #server commands generated - - label: - "Does the device implement sending the ChangeToModeResponse command?" - id: RVCCLEANMS.S.C03.Tx - - ## Dishwasher Mode control - - # Features - - label: - "Does the device support depending on an On/Off cluster implemented on - the same endpoint?" - id: DISHM.S.F00 - - # - # Server Attributes - # - - label: "Does the device implement the SupportedModes attribute?" - id: DISHM.S.A0000 - - - label: "Does the device implement the CurrentMode attribute?" - id: DISHM.S.A0001 - - - label: "Does the device implement the StartUpMode attribute?" - id: DISHM.S.A0002 - - - label: "Does the device implement the OnMode attribute?" - id: DISHM.S.A0003 - - # - #Server commands received - # - - label: "Does the device implement receiving the ChangeToMode command?" - id: DISHM.S.C00.Rsp - - # - #Server commands generated - # - - label: - "Does the device implement sending the ChangeToModeResponse command?" - id: DISHM.S.C01.Tx - # #Operational State # @@ -9003,10 +8993,18 @@ PICS: - label: "Does the device implement the LWM cluster as a server?" id: LWM.S + - label: "Does the DUT support testing the failed ChangeToMode command?" + id: LWM.S.M.CAN_TEST_MODE_FAILURE + - label: "Id of mode the device will fail to transition to, given its current state" - id: PIXIT.LWM.CAN_TEST_MODE_FAILURE + id: PIXIT.LWM.MODE_CHANGE_FAIL + + - label: + "Id of mode the device will successfully transition to, given its + current state" + id: PIXIT.LWM.MODE_CHANGE_OK # # server / features @@ -9085,21 +9083,36 @@ PICS: "Does the device implement sending the ChangeToModeResponse command?" id: RVCCLEANM.S.C01.Tx + - label: "Does the DUT support testing the failed ChangeToMode command?" + id: RVCCLEANM.S.M.CAN_TEST_MODE_FAILURE + - label: "Id of mode the device will fail to transition to, given its current state" - id: PIXIT.RVCCLEANM.CAN_TEST_MODE_FAILURE + id: PIXIT.RVCCLEANM.MODE_CHANGE_FAIL + - label: + "Id of mode the device will successfully transition to, given its + current state" + id: PIXIT.RVCCLEANM.MODE_CHANGE_OK # #Temperature Controlled Cabinet Mode Cluster # - label: "Does the device implement the TCCM cluster as a server?" id: TCCM.S + - label: "Does the DUT support testing the failed ChangeToMode command?" + id: TCCM.S.M.CAN_TEST_MODE_FAILURE + + - label: + "Id of mode the device will successfully transition to, given its + current state" + id: PIXIT.TCCM.MODE_CHANGE_OK + - label: "Id of mode the device will fail to transition to, given its current state" - id: PIXIT.TCCM.CAN_TEST_MODE_FAILURE + id: PIXIT.TCCM.MODE_CHANGE_FAIL #Features - label: @@ -9176,6 +9189,9 @@ PICS: device?" id: TCC.M.ManuallyControlledTemperature + - label: "Does the device support the INVALID_IN_MODE response" + id: TCTL.S.M.SupportsInvalidInMode + #Commands received - label: "Does the device implement receiving the SetTemperatureCommand @@ -9234,10 +9250,18 @@ PICS: - label: "Does the device implement the RVCRUNM cluster as a server?" id: RVCRUNM.S + - label: "Does the DUT support testing the failed ChangeToMode command?" + id: RVCRUNM.S.M.CAN_TEST_MODE_FAILURE + - label: "Id of mode the device will fail to transition to, given its current state" - id: PIXIT.RVCRUNM.CAN_TEST_MODE_FAILURE + id: PIXIT.RVCRUNM.MODE_CHANGE_FAIL + + - label: + "Id of mode the device will successfully transition to, given its + current state" + id: PIXIT.RVCRUNM.MODE_CHANGE_OK #Features - label: @@ -9448,4 +9472,4 @@ PICS: id: RVCOPSTATE.C.C02.Tx - label: "Does the device implement sending the Resume command?" - id: RVCOPSTATE.C.C04.Tx + id: RVCOPSTATE.C.C04.Tx \ No newline at end of file diff --git a/src/app/tests/suites/certification/ci-pics-values b/src/app/tests/suites/certification/ci-pics-values index 6ef9392d3af055..89f1390ab6a34c 100644 --- a/src/app/tests/suites/certification/ci-pics-values +++ b/src/app/tests/suites/certification/ci-pics-values @@ -307,7 +307,15 @@ DISHALM.S.A0000=1 DISHALM.S.A0001=1 DISHALM.S.A0002=1 DISHALM.S.A0003=1 -DISHALM.M.ManuallyControlled=1 + +#Manual controllable +DISHALM.S.M.ManuallyControlled=1 +DISHALM.S.M.InflowAlarmSupported=1 +DISHALM.S.M.DrainAlarmSupported=1 +DISHALM.S.M.DoorAlarmSupported=1 +DISHALM.S.M.TempLowAlarmSupported=1 +DISHALM.S.M.TempHighAlarmSupported=1 +DISHALM.S.M.WaterLevelAlarmSupported=1 #Commands DISHALM.S.C00.Rsp=1 @@ -329,7 +337,13 @@ DISHM.S.A0003=1 DISHM.S.C00.Rsp=1 DISHM.S.C01.Tx=1 -PIXIT.DISHM.CAN_TEST_MODE_FAILURE=1 + +#Manual controllable +DISHM.S.M.CAN_TEST_MODE_FAILURE=1 + +#PIXIT +PIXIT.DISHM.MODE_CHANGE_FAIL=1 +PIXIT.DISHM.MODE_CHANGE_OK=1 # MEDIA CLUSTER # App Launcher @@ -580,16 +594,16 @@ PRS.C.AO-WRITE=0 G.S=1 G.S.F00=1 G.S.A0000=0 -G.S.C00.Rsp=0 -G.S.C01.Rsp=0 -G.S.C02.Rsp=0 -G.S.C03.Rsp=0 +G.S.C00.Rsp=1 +G.S.C01.Rsp=1 +G.S.C02.Rsp=1 +G.S.C03.Rsp=1 G.S.C04.Rsp=0 G.S.C05.Rsp=0 -G.S.C00.Tx=0 -G.S.C01.Tx=0 -G.S.C02.Tx=0 -G.S.C03.Tx=0 +G.S.C00.Tx=1 +G.S.C01.Tx=1 +G.S.C02.Tx=1 +G.S.C03.Tx=1 G.C=1 G.C.A0000=0 @@ -603,7 +617,17 @@ G.C.C05.Tx=0 GRPKEY.S=1 # No support for the CacheAndSync feature so far GRPKEY.S.F00=0 -GRPKEY.S.A0001=0 +GRPKEY.S.A0000=1 +GRPKEY.S.A0001=1 +GRPKEY.S.A0002=1 +GRPKEY.S.A0003=1 + +GRPKEY.S.C00.Rsp=1 +GRPKEY.S.C01.Rsp=1 +GRPKEY.S.C02.Rsp=1 +GRPKEY.S.C03.Rsp=1 +GRPKEY.S.C04.Rsp=1 +GRPKEY.S.C05.Rsp=1 GRPKEY.C=1 GRPKEY.C.A0000=1 @@ -652,8 +676,6 @@ S.S.C40.Rsp=0 S.S.C41.Rsp=0 S.S.C42.Rsp=0 S.S.C05.Rsp=0 -G.S.C00.Rsp=0 -G.S.C04.Rsp=0 S.S.AM=0 S.S.AO=0 S.S.F00=0 @@ -763,7 +785,11 @@ LWM.S.F00=1 LWM.S.C00.Rsp=1 LWM.S.C01.Tx=1 -PIXIT.LWM.CAN_TEST_MODE_FAILURE=1 +#PIXIT +PIXIT.LWM.MODE_CHANGE_FAIL=1 +PIXIT.LWM.MODE_CHANGE_OK=1 + +LWM.S.M.CAN_TEST_MODE_FAILURE=1 # Time Format Localization Cluster LTIME.S=1 @@ -1446,7 +1472,7 @@ ILL.C.AO-WRITE=0 # Door Lock # Server attributes DRLK.S=1 -DRLK.S.DetectLockJammed=1 +DRLK.S.M.DetectLockJammed=1 DRLK.S.Simulate.NotFullyLocked=1 DRLK.S.A0000=1 DRLK.S.A0001=1 @@ -2039,7 +2065,7 @@ MCORE.ROLE.CONTROLLER=0 # Bridged Device Basic Information # Server BRBINFO.S=1 -BRBINFO.S.A0000=0 +BRBINFO.S.A0000=1 BRBINFO.S.A0001=0 BRBINFO.S.A0002=0 BRBINFO.S.A0003=0 @@ -2219,7 +2245,6 @@ AIRQUAL.S.F01=1 AIRQUAL.S.F02=1 AIRQUAL.S.F03=1 AIRQUAL.S.A0000=1 -PICS_USER_PROMPT=0 AIRQUAL.M.AirQualityChange=0 # Concentration Measurement @@ -2403,27 +2428,6 @@ TVOCCONC.S.A0008=1 TVOCCONC.S.A0009=1 TVOCCONC.S.A000a=1 -# TEMPERATURE CONTROL CLUSTER - -TCTL.S=1 -TCTL.C=1 - -TCTL.S.F00=1 -TCTL.S.F01=1 -TCTL.S.F02=1 - -#Server -TCTL.S.A0000=1 -TCTL.S.A0001=1 -TCTL.S.A0002=1 -TCTL.S.A0003=1 -TCTL.S.A0004=1 -TCTL.S.A0005=1 -TCC.M.ManuallyControlledTemperature=1 - -#Command -TCTL.S.C00.Rsp=1 -TCTL.C.C00.Tx=1 RNCONC.C=0 @@ -2479,7 +2483,11 @@ RVCCLEANM.S.F00=1 RVCCLEANM.S.C00.Rsp=1 RVCCLEANM.S.C01.Tx=1 -PIXIT.RVCCLEANM.CAN_TEST_MODE_FAILURE=1 +RVCCLEANM.S.M.CAN_TEST_MODE_FAILURE=1 + +#PIXIT +PIXIT.RVCCLEANM.MODE_CHANGE_FAIL=1 +PIXIT.RVCCLEANM.MODE_CHANGE_OK=1 # RVC OPERATIONAL STATE CLUSTER RVCOPSTATE.S=1 @@ -2545,7 +2553,11 @@ RVCRUNM.S.A0003=1 RVCRUNM.S.C00.Rsp=1 RVCRUNM.S.C01.Tx=1 -PIXIT.RVCRUNM.CAN_TEST_MODE_FAILURE=1 +RVCRUNM.S.M.CAN_TEST_MODE_FAILURE=1 + +#PIXIT +PIXIT.RVCRUNM.MODE_CHANGE_FAIL=1 +PIXIT.RVCRUNM.MODE_CHANGE_OK=1 #Refrigerator and Temperature Controlled Cabinet Mode Cluster(TCCM) @@ -2562,6 +2574,11 @@ TCCM.S.A0003=1 TCCM.S.C00.Rsp=1 TCCM.S.C01.Tx=1 +TCCM.S.M.CAN_TEST_MODE_FAILURE=1 + +#PIXIT +PIXIT.TCCM.MODE_CHANGE_FAIL=1 +PIXIT.TCCM.MODE_CHANGE_OK=1 # Fan Control #Features @@ -2667,14 +2684,12 @@ TCCM.S.A0003=1 TCCM.S.C00.Rsp=1 TCCM.S.C01.Tx=1 -PIXIT.TCCM.CAN_TEST_MODE_FAILURE=1 - #Temperature Control TCTL.S=1 TCTL.C=1 -TCTL.S.F00=1 +TCTL.S.F00=0 TCTL.S.F01=1 -TCTL.S.F02=1 +TCTL.S.F02=0 TCTL.S.A0000=1 TCTL.S.A0001=1 TCTL.S.A0002=1 @@ -2682,6 +2697,7 @@ TCTL.S.A0003=1 TCTL.S.A0004=1 TCTL.S.A0005=1 TCC.M.ManuallyControlledTemperature=1 +TCTL.S.M.SupportsInvalidInMode=1 TCTL.S.C00.Rsp=1 TCTL.C.C00.Tx=1 @@ -2717,4 +2733,4 @@ REFALM.S.A0002=1 REFALM.S.A0003=1 REFALM.S.E00=1 REFALM.S.C00.Rsp=1 -REFALM.S.C01.Rsp=1 +REFALM.S.C01.Rsp=1 \ No newline at end of file