Skip to content

Migrate nvd importer to importer-improver model #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2022
Merged

Migrate nvd importer to importer-improver model #664

merged 5 commits into from
Apr 9, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Apr 4, 2022

No description provided.

@TG1999 TG1999 force-pushed the new_importer/nvd branch from 424853b to 494cde4 Compare April 4, 2022 18:07
@TG1999
Migrate nvd importer to importer-improver model
3aaa7c0 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the new_importer/nvd branch from 494cde4 to 3aaa7c0 Compare April 4, 2022 18:11
@TG1999
Add spdx license expression
bff3444 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@pombredanne pombredanne mentioned this pull request Apr 5, 2022
Closed
@TG1999 TG1999 marked this pull request as draft April 5, 2022 19:43
@TG1999 TG1999 marked this pull request as ready for review April 6, 2022 12:53
pombredanne
pombredanne reviewed Apr 6, 2022
View reviewed changes
JonoYang
JonoYang reviewed Apr 7, 2022
View reviewed changes
JonoYang
JonoYang reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 I've looked over the code, mainly for style, but I had a question about the removal of tests from test_nvd.py

pombredanne
pombredanne requested changes Apr 8, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! See some feedback for your review.

This was referenced Apr 8, 2022
Open
Open
@TG1999
Add unit tests and make model changes for storing cpe as reference_id
08beb9f 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the new_importer/nvd branch from 167ed5d to 08beb9f Compare April 8, 2022 19:31
pombredanne
pombredanne approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM... with a few minor nit: I would like the reference id field to be an even 200 chars and there are a few things that can refine in the future like the get_items() approach.

@pombredanne
Add link to NVD License issue
c9c96c0 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Set reference_id length to 200
ec3e564 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

Merging now

@pombredanne pombredanne merged commit c992168 into aboutcode-org:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonoYang JonoYang JonoYang left review comments

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TG1999 @pombredanne @JonoYang