Add unspecified scoring system #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hritik14
force-pushed
the
scoring_system
branch
from
4bcf554 to
8c7c114
Compare
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
sbs2001
requested changes
Apr 2, 2021
There was a problem hiding this comment.
@Hritik14 it makes sense to have something when there's no doc for severities.
But in this case I think we are losing information by calling it "unspecified" .
IMHO we should call it "generic_textual". That way the downstream projects would be still able to interpret these. And we should give the url a default value of empty string.
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
|
@sbs2001 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be used where the scale of scoring system is unspecified and do not correspond to a numeric representation. This must be used as the last resort.
Required in #397 (comment) and #393 (comment)
Signed-off-by: Hritik Vijay hritikxx8@gmail.com