Skip to content

Conversation

@keshav-space
Copy link
Member

@TG1999
Copy link
Contributor

TG1999 commented Sep 12, 2024

@keshav-space is there anything remaining here, can we go ahead and review / merge this ?

@keshav-space
Copy link
Member Author

is there anything remaining here, can we go ahead and review / merge this ?

@TG1999 I will add a small data migration to change the value of created_by field on the old npm advisory to our new pipeline_id, and then ping you for review/merge.

@TG1999
Copy link
Contributor

TG1999 commented Sep 12, 2024

@keshav-space sure, let me know when it's ready for review

@keshav-space keshav-space force-pushed the npm-importer-pipeline branch 2 times, most recently from 759a090 to 04442b7 Compare September 13, 2024 11:36
@keshav-space keshav-space requested a review from TG1999 September 13, 2024 11:40
@keshav-space
Copy link
Member Author

sure, let me know when it's ready for review

@TG1999 ready for your review :)

@TG1999
Copy link
Contributor

TG1999 commented Sep 17, 2024

ping @TG1999

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- For now pipeline_id should be module name of pipeline

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- Update the created_by field on old advisory to new pipeline_id

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keshav-space
Copy link
Member Author

Log from a clean run.

❯ python3 manage.py import npm_importer
Importing data using npm_importer
INFO 2024-09-19 13:54:21.715 Pipeline [NpmImporterPipeline] starting
INFO 2024-09-19 13:54:21.715 Step [clone] starting
INFO 2024-09-19 13:54:21.715 Cloning `git+https://github.com/nodejs/security-wg`
INFO 2024-09-19 13:54:23.075 Step [clone] completed in 1 seconds
INFO 2024-09-19 13:54:23.076 Step [collect_and_store_advisories] starting
INFO 2024-09-19 13:54:23.157 Progress: 10% (47/468) ETA: 1 seconds
INFO 2024-09-19 13:54:23.251 Progress: 20% (94/468) ETA: 1 seconds
INFO 2024-09-19 13:54:23.327 Progress: 30% (141/468) ETA: 1 seconds
INFO 2024-09-19 13:54:23.380 Successfully collected 176 advisories
INFO 2024-09-19 13:54:23.380 Step [collect_and_store_advisories] completed in 0 seconds
INFO 2024-09-19 13:54:23.380 Step [import_new_advisories] starting
INFO 2024-09-19 13:54:23.381 Importing 176 new advisories
INFO 2024-09-19 13:54:23.567 Progress: 10% (18/176) ETA: 2 seconds
INFO 2024-09-19 13:54:23.738 Progress: 20% (36/176) ETA: 1 seconds
INFO 2024-09-19 13:54:23.925 Progress: 30% (53/176) ETA: 1 seconds
INFO 2024-09-19 13:54:24.182 Progress: 40% (71/176) ETA: 1 seconds
Failed to get exact purls for: AffectedPackage(package=PackageURL(type='npm', namespace=None, name='fury-adapter-swagger', version=None, qualifiers={}, subpath=None), affected_version_range=NpmVersionRange(constraints=(VersionConstraint(comparator='>=', version=SemverVersion(string='0.2.0')), VersionConstraint(comparator='>=', version=SemverVersion(string='0.8.0-pre')), VersionConstraint(comparator='<', version=SemverVersion(string='0.8.0')), VersionConstraint(comparator='>=', version=SemverVersion(string='0.8.0')), VersionConstraint(comparator='<', version=SemverVersion(string='0.8.1')), VersionConstraint(comparator='<=', version=SemverVersion(string='0.9.6')))), fixed_version=None) with error: InvalidConstraintsError("Invalid constraints sequence: ('>= 0.2.0','>= 0.8.0-pre') in [VersionConstraint(comparator='>=', version=SemverVersion(string='0.2.0')), VersionConstraint(comparator='>=', version=SemverVersion(string='0.8.0-pre')), VersionConstraint(comparator='<', version=SemverVersion(string='0.8.0')), VersionConstraint(comparator='>=', version=SemverVersion(string='0.8.0')), VersionConstraint(comparator='<', version=SemverVersion(string='0.8.1')), VersionConstraint(comparator='<=', version=SemverVersion(string='0.9.6'))]")
INFO 2024-09-19 13:54:24.419 Progress: 50% (88/176) ETA: 1 seconds
INFO 2024-09-19 13:54:24.616 Progress: 60% (106/176) ETA: 1 seconds
Failed to get exact purls for: AffectedPackage(package=PackageURL(type='npm', namespace=None, name='node.extend', version=None, qualifiers={}, subpath=None), affected_version_range=NpmVersionRange(constraints=(VersionConstraint(comparator='<', version=SemverVersion(string='1.1.7')), VersionConstraint(comparator='<', version=SemverVersion(string='2.0.1')))), fixed_version=None) with error: InvalidConstraintsError("Invalid constraints sequence: ('< 1.1.7','< 2.0.1') in [VersionConstraint(comparator='<', version=SemverVersion(string='1.1.7')), VersionConstraint(comparator='<', version=SemverVersion(string='2.0.1'))]")
INFO 2024-09-19 13:54:24.798 Progress: 70% (124/176) ETA: 1 seconds
INFO 2024-09-19 13:54:24.975 Progress: 80% (141/176)
INFO 2024-09-19 13:54:25.182 Progress: 90% (159/176)
INFO 2024-09-19 13:54:25.337 Progress: 100% (176/176)
Failed to get exact purls for: AffectedPackage(package=PackageURL(type='npm', namespace=None, name='electron', version=None, qualifiers={}, subpath=None), affected_version_range=NpmVersionRange(constraints=(VersionConstraint(comparator='<', version=SemverVersion(string='2.0.18')), VersionConstraint(comparator='<', version=SemverVersion(string='3.0.16')), VersionConstraint(comparator='<', version=SemverVersion(string='3.1.6')), VersionConstraint(comparator='<', version=SemverVersion(string='4.0.8')), VersionConstraint(comparator='<', version=SemverVersion(string='5.0.0-beta.5')))), fixed_version=None) with error: InvalidConstraintsError("Invalid constraints sequence: ('< 2.0.18','< 3.0.16') in [VersionConstraint(comparator='<', version=SemverVersion(string='2.0.18')), VersionConstraint(comparator='<', version=SemverVersion(string='3.0.16')), VersionConstraint(comparator='<', version=SemverVersion(string='3.1.6')), VersionConstraint(comparator='<', version=SemverVersion(string='4.0.8')), VersionConstraint(comparator='<', version=SemverVersion(string='5.0.0-beta.5'))]")
INFO 2024-09-19 13:54:25.363 Successfully imported 176 new advisories
INFO 2024-09-19 13:54:25.364 Step [import_new_advisories] completed in 2 seconds
INFO 2024-09-19 13:54:25.364 Step [clean_downloads] starting
INFO 2024-09-19 13:54:25.364 Removing cloned repository
INFO 2024-09-19 13:54:25.371 Step [clean_downloads] completed in 0 seconds
INFO 2024-09-19 13:54:25.371 Pipeline completed in 4 seconds

@keshav-space keshav-space merged commit 094c2bf into main Sep 19, 2024
@keshav-space keshav-space deleted the npm-importer-pipeline branch September 19, 2024 14:04
@pombredanne pombredanne added 1-next and removed 9-next labels Sep 24, 2024
@pombredanne pombredanne moved this to Validated in 00-AboutCodePlanner Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project
Status: Validated

Development

Successfully merging this pull request may close these issues.

3 participants