Check if weakness exists in DB or not

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/api.py

@@ -131,6 +131,15 @@ class Meta:
         model = Weakness
         fields = ["cwe_id", "name", "description"]
 
+    def to_representation(self, instance):
+        """
+        Override to include 'weakness' only if it is not None.
+        """
+        representation = super().to_representation(instance)
+        if instance.weakness is None:
+            return None
+        return representation
+
 
 class VulnerabilitySerializer(serializers.HyperlinkedModelSerializer):
     fixed_packages = MinimalPackageSerializer(
@@ -142,6 +151,15 @@ class VulnerabilitySerializer(serializers.HyperlinkedModelSerializer):
     aliases = AliasSerializer(many=True, source="alias")
     weaknesses = WeaknessSerializer(many=True)
 
+    def to_representation(self, instance):
+        representation = super().to_representation(instance)
+
+        # Exclude None values from the weaknesses list
+        weaknesses = representation.get("weaknesses", [])
+        representation["weaknesses"] = [weakness for weakness in weaknesses if weakness is not None]
+
+        return representation
+
     class Meta:
         model = Vulnerability
         fields = [

vulnerabilities/models.py

@@ -316,6 +316,9 @@ def description(self):
         """Return the weakness's description."""
         return self.weakness.description if self.weakness else ""
 
+    def to_dict(self):
+        return {"cwe_id": self.cwe_id, "name": self.name, "description": self.description}
+
 
 class VulnerabilityReferenceQuerySet(BaseQuerySet):
     def for_cpe(self):

vulnerabilities/tests/test_api.py

@@ -245,11 +245,6 @@ def test_api_with_single_vulnerability(self):
                     "name": "Improper Restriction of Operations within the Bounds of a Memory Buffer",
                     "description": "The software performs operations on a memory buffer, but it can read from or write to a memory location that is outside of the intended boundary of the buffer.",
                 },
-                {
-                    "cwe_id": 10000,
-                    "name": "",
-                    "description": "",
-                },
             ],
         }
 
@@ -278,11 +273,6 @@ def test_api_with_single_vulnerability_with_filters(self):
                     "name": "Improper Restriction of Operations within the Bounds of a Memory Buffer",
                     "description": "The software performs operations on a memory buffer, but it can read from or write to a memory location that is outside of the intended boundary of the buffer.",
                 },
-                {
-                    "cwe_id": 10000,
-                    "name": "",
-                    "description": "",
-                },
             ],
         }
 

vulnerabilities/tests/test_data/suse_oval/suse-oval-CVE-2008-5679-expected.json

@@ -10,9 +10,9 @@
           "type": "rpm",
           "namespace": "opensuse",
           "name": "opera",
-          "version": null,
-          "qualifiers": null,
-          "subpath": null
+          "version": "",
+          "qualifiers": "",
+          "subpath": ""
         },
         "affected_version_range": "vers:rpm/<9.63-1.1",
         "fixed_version": null
@@ -29,4 +29,4 @@
     "weaknesses": [],
     "url": ""
   }
-]
+]