Skip to content

Commit c6dec36

Browse files
committed
Return a list of purls instead of dicts
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 19393fc commit c6dec36

File tree

2 files changed

+13
-26
lines changed

2 files changed

+13
-26
lines changed

vulnerabilities/api.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -185,16 +185,6 @@ class Meta:
185185
]
186186

187187

188-
class VulnerablePackageSerializer(serializers.HyperlinkedModelSerializer):
189-
purl = serializers.CharField(source="package_url")
190-
191-
class Meta:
192-
model = Package
193-
fields = [
194-
"purl",
195-
]
196-
197-
198188
class PackageFilterSet(filters.FilterSet):
199189
purl = filters.CharFilter(method="filter_purl")
200190

@@ -269,11 +259,8 @@ def all(self, request):
269259
vulnerable_packages = Package.objects.filter(
270260
packagerelatedvulnerability__fix=False
271261
).distinct()
272-
return Response(
273-
VulnerablePackageSerializer(
274-
vulnerable_packages, many=True, context={"request": request}
275-
).data
276-
)
262+
vulnerable_purls = [p.purl for p in vulnerable_packages]
263+
return Response(vulnerable_purls)
277264

278265

279266
class VulnerabilityFilterSet(filters.FilterSet):

vulnerabilities/tests/test_fix_api.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -269,17 +269,17 @@ def test_api_with_all_vulnerable_packages(self):
269269
response = self.csrf_client.get(f"/api/packages/all", format="json").data
270270
assert len(response) == 11
271271
assert response == [
272-
{"purl": "pkg:generic/nginx/test@0"},
273-
{"purl": "pkg:generic/nginx/test@1"},
274-
{"purl": "pkg:generic/nginx/test@11"},
275-
{"purl": "pkg:generic/nginx/test@2"},
276-
{"purl": "pkg:generic/nginx/test@3"},
277-
{"purl": "pkg:generic/nginx/test@4"},
278-
{"purl": "pkg:generic/nginx/test@5"},
279-
{"purl": "pkg:generic/nginx/test@6"},
280-
{"purl": "pkg:generic/nginx/test@7"},
281-
{"purl": "pkg:generic/nginx/test@8"},
282-
{"purl": "pkg:generic/nginx/test@9"},
272+
"pkg:generic/nginx/test@0",
273+
"pkg:generic/nginx/test@1",
274+
"pkg:generic/nginx/test@11",
275+
"pkg:generic/nginx/test@2",
276+
"pkg:generic/nginx/test@3",
277+
"pkg:generic/nginx/test@4",
278+
"pkg:generic/nginx/test@5",
279+
"pkg:generic/nginx/test@6",
280+
"pkg:generic/nginx/test@7",
281+
"pkg:generic/nginx/test@8",
282+
"pkg:generic/nginx/test@9",
283283
]
284284

285285

0 commit comments

Comments
 (0)