Create new option for license URL template #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new argument in `get_licenses()` in `api.py` to pass in a URL template with the default being the current DejaCode URL template
* Create new CLI option in `cli.py` to get a URL template from the command line and pass it to `get_licenses()`
Signed-off-by: Jonathan "Jono" Yang <jyang@nexb.com>
Signed-off-by: Jonathan "Jono" Yang <jyang@nexb.com>
Signed-off-by: Jonathan "Jono" Yang <jyang@nexb.com>
Signed-off-by: Jonathan "Jono" Yang <jyang@nexb.com>
Signed-off-by: Jonathan "Jono" Yang <jyang@nexb.com>
Signed-off-by: Jonathan "Jono" Yang <jyang@nexb.com>
Codecov Report
@@ Coverage Diff @@
## develop #771 +/- ##
===========================================
+ Coverage 78.19% 78.57% +0.37%
===========================================
Files 91 91
Lines 11265 11267 +2
===========================================
+ Hits 8809 8853 +44
+ Misses 2456 2414 -42
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #759, users are now able to specify custom license URL templates with the new command line option
--license-url-template. The user would pass in the URL template as so:scancode -l --license-url-template "https://example.com/urn:{}" example_directorywhere
{}is the placeholder for the license key. Also, the fielddejacode_urlhas now been renamedreference_url.