Updated manifest detection in classify.py to use dynamically detect manifest files from registered handlers #4230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the _MANIFEST_ENDS list in summarycode/classify.py , that was a hardcoded list of extensions with a dynamically generated set of manifest file extensions derived from APPLICATION_PACKAGE_DATAFILE_HANDLERS.
Added
get_dynamic_manifestends()
function to generate the manifest extensions from the handler path_patterns. Also updated the _MANIFEST_ENDS list so that now it uses the newly added function to get file extensions dynamically.This change ensures:
More accurate and consistent manifest detection.
Easier maintenance when new package handlers are being added.
Less duplication of extension logic.
Fixes #4225
Tasks
Run tests locally to check for errors.
Signed-off-by: Lakshay Bhatia 08Lakshay@gmail.com