Introduce Rules with YAML frontmatter #3049 #3063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyanSinhaMahapatra
changed the title
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
This commit ends the process of merging .RULE and .yml files into a single .RULE file which has YAML frontmatter storing the rule metadata present in the .yml file previously. This renaming and merging has been done to preserve line-history for both the files. Reference: #3049 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
3049-too-many-files
branch
from
9c7a6bb to
e71edc1
Compare
Member
Author
|
The merging of the .RULE and .yml files to .RULE files with YAML frontmatter has been done such that the This blogpost has been followed for the same. Though note that this preserves only line history, i.e. entire history isn't tracked as the files are renamed (and git doesn't track history for renamed files see here). But you can still get the file history for these files by using |
* Import and use functions/classes from frontmatter * Copy and modify class to use saneyaml * Copy and modify load/parse functions * Add .ABOUT and LICENSE files. Signed-off-by: AyanSinhaMahapatra <ayansmahapatra@gmail.com>
Rule classmethod from_files is renamed and modified to from_file and now takes only the rule_file as argument. Also modifies tests to use frontmatter. Signed-off-by: AyanSinhaMahapatra <ayansmahapatra@gmail.com>
Modify test .RULE .yml file pairs to a single .RULE file with YAML frontmatter. Signed-off-by: AyanSinhaMahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
3049-too-many-files
branch
from
3c8b69c to
89d62ae
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Member
Author
|
@pombredanne btw, should we do the same for |
AyanSinhaMahapatra
changed the title
4 tasks
Member
|
This is already all in #3100 ... so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #3049
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com