Update DatafileHandler default methods #3042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Yield Packages and Dependencies before associating Packages to Resources Signed-off-by: Jono Yang <jyang@nexb.com>
Member
Author
|
On second thought, it makes more sense to sort the assembly items after the fact in scancode.io than it is to mandate every |
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update assemble methods for alpine and debian to yield Packages first before other items Signed-off-by: Jono Yang <jyang@nexb.com>
Member
Author
|
I've updated the rest of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
DatafileHandler.assemble()andDatafileHandler.assemble_from_many()to yield Packages, Dependencies, and Resources before associating Packages to Resources using apackage_adder. This is to help with using packagedcode Package handlers in scancode.io, where a Package needs to be created in scancode.io before it can be associated with a Resource.