Support shortcut flags for cli #2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
requested changes
May 13, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
These are all making sense! Thanks. Do you mind to also keep some test that uses the long form version?
And also add you name to the AUTHORs and update the changelog ?
Thanks!
Author
There are many tests which use long form version, I've altered only some of them to test for short flags but now I have added few more changes to other functions. The tests will now use both short form and long form versions |
lf32
force-pushed
the
shortcut-flgs
branch
2 times, most recently
from
d7c3e7d to
9912ab7
Compare
lf32
force-pushed
the
shortcut-flgs
branch
4 times, most recently
from
37a1ea7 to
ef669a7
Compare
Signed-off-by: Akhil Raj <lf32.dev@gmail.com>
Author
|
Is everything ok with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
shortcut flags
Fixes #2949