Skip to content

Commit eae13cf

Browse files
TG1999swastkk
authored andcommitted
Replaced Packaging module with Packvers in different files.
Signed-off-by: swastik <swastkk@gmail.com>
1 parent a5891f4 commit eae13cf

17 files changed

+86
-532
lines changed

CHANGELOG.rst

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ v0.9.3
66
------
77

88
- Add support for recursive requirements.
9-
- Add python 3.11 as a valid python version in choices.
10-
- Operating system and python version are now required fields in CLI.
11-
- Add dot versions (3.6, 3.7, 3.8, 3.9, 3.10, 3.11, 2.7) with
12-
current python version choices for CLI (36, 37, 38, 39, 310, 311, 27).
139

1410

1511
v0.9.2

requirements.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,14 @@ charset-normalizer==2.1.0
55
click==8.1.3
66
colorama==0.4.5
77
commoncode==30.2.0
8-
dparse2==0.6.1
8+
dparse2==0.7.0
99
idna==3.3
1010
importlib-metadata==4.12.0
1111
intbitset==3.0.1
1212
packageurl-python==0.10.0
1313
packaging==21.3
14-
pip-requirements-parser==31.2.0
14+
packvers==21.5
15+
pip-requirements-parser==32.0.1
1516
pkginfo2==30.0.0
1617
pyparsing==3.0.9
1718
PyYAML==6.0

setup.cfg

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,19 @@ install_requires =
5858
click > 7.0
5959
colorama >= 0.3.9
6060
commoncode >= 30.0.0
61-
dparse2 >= 0.6.1
61+
dparse2 >= 0.7.0
6262
importlib_metadata >= 4.12.0
6363
packageurl_python >= 0.9.0
6464
pkginfo2 >= 30.0.0
65-
pip-requirements-parser >= 31.2.0
65+
pip-requirements-parser >= 32.0.1
6666
requests >= 2.18.0
6767
resolvelib >= 0.8.1
6868
saneyaml >= 0.5.2
6969
tinynetrc >= 1.3.1
7070
toml >= 0.10.0
7171
mock >= 3.0.5
72-
72+
packaging >= 21.0.0
73+
packvers >= 21.5
7374
[options.packages.find]
7475
where = src
7576

src/_packagedcode/pypi.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,14 @@
2222
import zipfile
2323

2424
import dparse2
25-
import packaging
25+
import packvers as packaging
2626
import pip_requirements_parser
27-
import pkginfo2
2827
from commoncode import fileutils
29-
from packaging.specifiers import SpecifierSet
28+
from packvers.specifiers import SpecifierSet
3029
from packageurl import PackageURL
31-
from packaging import markers
32-
from packaging.requirements import Requirement
33-
from packaging.utils import canonicalize_name
30+
from packvers import markers
31+
from packvers.requirements import Requirement
32+
from packvers.utils import canonicalize_name
3433

3534
from _packagedcode import models
3635
from _packagedcode.utils import build_description

src/python_inspector/api.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from typing import Sequence
1717

1818
from packageurl import PackageURL
19-
from packaging.requirements import Requirement
19+
from packvers.requirements import Requirement
2020
from resolvelib import BaseReporter
2121
from resolvelib import Resolver
2222
from tinynetrc import Netrc
@@ -40,8 +40,8 @@
4040
from python_inspector.resolution import get_requirements_from_python_manifest
4141
from python_inspector.utils_pypi import PLATFORMS_BY_OS
4242
from python_inspector.utils_pypi import PYPI_SIMPLE_URL
43+
from python_inspector.utils_pypi import PYTHON_DOT_VERSIONS_BY_VER
4344
from python_inspector.utils_pypi import Environment
44-
from python_inspector.utils_pypi import valid_python_versions
4545

4646

4747
class Resolution(NamedTuple):
@@ -103,6 +103,9 @@ def resolve_dependencies(
103103
f"Must be one of: {', '.join(PLATFORMS_BY_OS.keys())}"
104104
)
105105

106+
valid_python_versions = list(PYTHON_DOT_VERSIONS_BY_VER.keys())
107+
valid_python_versions.extend([dot_ver for pyver, dot_ver in PYTHON_DOT_VERSIONS_BY_VER.items()])
108+
106109
if not python_version:
107110
raise Exception(f"No python version provided.")
108111
if python_version not in valid_python_versions:

src/python_inspector/dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#
1111

1212
from packageurl import PackageURL
13-
from packaging.requirements import Requirement
13+
from packvers.requirements import Requirement
1414
from pip_requirements_parser import InstallRequirement
1515

1616
from _packagedcode import models

src/python_inspector/resolution.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818
from typing import Union
1919
from zipfile import ZipFile
2020

21-
import packaging.utils
21+
import packvers.utils
2222
from packageurl import PackageURL
23-
from packaging.requirements import Requirement
24-
from packaging.version import LegacyVersion
25-
from packaging.version import Version
26-
from packaging.version import parse as parse_version
23+
from packvers.requirements import Requirement
24+
from packvers.version import LegacyVersion
25+
from packvers.version import Version
26+
from packvers.version import parse as parse_version
2727
from resolvelib import AbstractProvider
2828
from resolvelib.structs import DirectedGraph
2929

@@ -325,7 +325,7 @@ def __init__(
325325

326326
def identify(self, requirement_or_candidate: Union[Candidate, Requirement]) -> str:
327327
"""Given a requirement, return an identifier for it. Overridden."""
328-
name = packaging.utils.canonicalize_name(requirement_or_candidate.name)
328+
name = packvers.utils.canonicalize_name(requirement_or_candidate.name)
329329
if requirement_or_candidate.extras:
330330
extras_str = ",".join(sorted(requirement_or_candidate.extras))
331331
return "{}[{}]".format(name, extras_str)
@@ -576,7 +576,7 @@ def _iter_dependencies(self, candidate: Candidate) -> Generator[Requirement, Non
576576
"""
577577
Yield dependencies for the given candidate.
578578
"""
579-
name = packaging.utils.canonicalize_name(candidate.name)
579+
name = packvers.utils.canonicalize_name(candidate.name)
580580
# TODO: handle extras https://github.com/nexB/python-inspector/issues/10
581581
if candidate.extras:
582582
r = f"{name}=={candidate.version}"

src/python_inspector/resolve_cli.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,9 @@ def print_version(ctx, param, value):
7070
"-p",
7171
"--python-version",
7272
"python_version",
73-
type=click.Choice(utils_pypi.valid_python_versions),
73+
type=click.Choice(utils_pypi.PYTHON_VERSIONS),
7474
metavar="PYVER",
7575
show_default=True,
76-
required=True,
7776
help="Python version to use for dependency resolution.",
7877
)
7978
@click.option(
@@ -83,7 +82,6 @@ def print_version(ctx, param, value):
8382
type=click.Choice(utils_pypi.PLATFORMS_BY_OS),
8483
metavar="OS",
8584
show_default=True,
86-
required=True,
8785
help="OS to use for dependency resolution.",
8886
)
8987
@click.option(

src/python_inspector/setup_py_live_eval.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import mock
2222
import setuptools
2323
from commoncode.command import pushd
24-
from packaging.requirements import Requirement
24+
from packvers.requirements import Requirement
2525

2626

2727
def minver_error(pkg_name):

src/python_inspector/utils_pip_compatibility_tags.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727

2828
import re
2929

30-
from packaging.tags import compatible_tags
31-
from packaging.tags import cpython_tags
32-
from packaging.tags import generic_tags
33-
from packaging.tags import interpreter_name
34-
from packaging.tags import interpreter_version
35-
from packaging.tags import mac_platforms
30+
from packvers.tags import compatible_tags
31+
from packvers.tags import cpython_tags
32+
from packvers.tags import generic_tags
33+
from packvers.tags import interpreter_name
34+
from packvers.tags import interpreter_version
35+
from packvers.tags import mac_platforms
3636

3737
_osx_arch_pat = re.compile(r"(.+)_(\d+)_(\d+)_(.+)")
3838

0 commit comments

Comments
 (0)