Skip to content

Commit 10c22ec

Browse files
committed
Do not use a default global
using a function argument with default mutable collection is a problem Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent ccfe258 commit 10c22ec

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

src/python_inspector/resolve_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ def resolve(
377377

378378

379379
def get_requirements_from_direct_dependencies(
380-
direct_dependencies: List[DependentPackage], environment_marker: Dict = {}
380+
direct_dependencies: List[DependentPackage], environment_marker: Dict
381381
) -> List[Requirement]:
382382
for dependency in direct_dependencies:
383383
# FIXME We are skipping editable requirements

tests/test_cli.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,13 +368,23 @@ def test_get_requirements_from_direct_dependencies():
368368
)
369369
]
370370

371-
requirements = [str(r) for r in get_requirements_from_direct_dependencies(direct_dependencies)]
371+
requirements = [
372+
str(r)
373+
for r in get_requirements_from_direct_dependencies(
374+
direct_dependencies=direct_dependencies, environment_marker={}
375+
)
376+
]
372377

373378
assert requirements == ["django>=1.11.11"]
374379

375380

376381
def test_get_requirements_from_direct_dependencies_with_empty_list():
377-
assert list(get_requirements_from_direct_dependencies(direct_dependencies=[])) == []
382+
assert (
383+
list(
384+
get_requirements_from_direct_dependencies(direct_dependencies=[], environment_marker={})
385+
)
386+
== []
387+
)
378388

379389

380390
def test_get_requirements_from_direct_dependencies_with_editable_requirements():
@@ -401,6 +411,11 @@ def test_get_requirements_from_direct_dependencies_with_editable_requirements():
401411
)
402412
]
403413

404-
requirements = [str(r) for r in get_requirements_from_direct_dependencies(direct_dependencies)]
414+
requirements = [
415+
str(r)
416+
for r in get_requirements_from_direct_dependencies(
417+
direct_dependencies=direct_dependencies, environment_marker={}
418+
)
419+
]
405420

406421
assert requirements == []

tests/test_resolution.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test_without_supported_wheels():
145145
"pkg:pypi/hyperlink@21.0.0",
146146
"pkg:pypi/idna@3.3",
147147
"pkg:pypi/pycparser@2.21",
148-
"pkg:pypi/setuptools@64.0.1",
148+
"pkg:pypi/setuptools@65.0.0",
149149
"pkg:pypi/txaio@22.2.1",
150150
]
151151

0 commit comments

Comments
 (0)