Skip to content

Commit bb256ef

Browse files
author
Martin Konicek
committed
Revert "Move react to peerDependencies"
This reverts commit 9f01f96.
1 parent 481b335 commit bb256ef

File tree

3 files changed

+1
-24
lines changed

3 files changed

+1
-24
lines changed

local-cli/generator/index.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,5 @@ module.exports = yeoman.generators.NamedBase.extend({
8282
{name: this.name}
8383
);
8484
}
85-
},
86-
87-
install: function() {
88-
if (this.options.upgrade) {
89-
return;
90-
}
91-
92-
this.npmInstall('react', { '--save': true });
9385
}
9486
});

local-cli/upgrade/upgrade.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,6 @@ module.exports = function upgrade(args, config) {
4444
'https://github.com/facebook/react-native/releases/tag/v' + semver.major(v) + '.' + semver.minor(v) + '.0'
4545
)
4646
);
47-
48-
// >= v0.21.0, we require react to be a peer depdendency
49-
if (semver.gte(v, '0.21.0') && !pak.dependencies['react']) {
50-
console.log(
51-
chalk.yellow(
52-
'\nYour \'package.json\' file doesn\'t seem to have \'react\' as a dependency.\n' +
53-
'\'react\' was changed from a dependency to a peer dependency in react-native v0.21.0.\n' +
54-
'Therefore, it\'s necessary to include \'react\' in your project\'s dependencies.\n' +
55-
'Just run \'npm install --save react\', then re-run \'react-native upgrade\'.\n'
56-
)
57-
);
58-
return Promise.resolve();
59-
}
6047
} else {
6148
console.log(
6249
chalk.yellow(

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,6 @@
102102
"bin": {
103103
"react-native": "local-cli/wrong-react-native.js"
104104
},
105-
"peerDependencies": {
106-
"react": "^0.14.5"
107-
},
108105
"dependencies": {
109106
"absolute-path": "^0.0.0",
110107
"art": "^0.10.0",
@@ -136,6 +133,7 @@
136133
"optimist": "^0.6.1",
137134
"progress": "^1.1.8",
138135
"promise": "^7.1.1",
136+
"react": "^0.14.5",
139137
"react-timer-mixin": "^0.13.2",
140138
"react-transform-hmr": "^1.0.2",
141139
"rebound": "^0.0.13",

0 commit comments

Comments
 (0)