Skip to content
This repository was archived by the owner on Feb 14, 2023. It is now read-only.

Support stacked borrows in BufWriter::into_inner_ #15

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

LunaBorowska
Copy link
Contributor

@LunaBorowska LunaBorowska commented Jul 31, 2019

This avoids errors in miri due to mem::forget currently behaving like a regular function call.

Also see rust-lang/rust#62610.

@LunaBorowska LunaBorowska force-pushed the support-stacked-borrows branch from 7a2cbe8 to b89a914 Compare July 31, 2019 11:21
This avoids errors in miri due to mem::forget currently behaving
like a regular function call with the current stacked borrows
model.
@LunaBorowska LunaBorowska force-pushed the support-stacked-borrows branch from b89a914 to e6370a9 Compare July 31, 2019 11:21
@abonander
Copy link
Owner

Looks good to me! I don't remember what minimum Rust version I intended to support but 1.20 is probably old enough (and I'm probably accidentally requiring something newer anyway).

Does this need an immediate publish like the safemem upgrade?

@abonander abonander merged commit f6fbee6 into abonander:master Jul 31, 2019
@abonander
Copy link
Owner

Published as 0.8.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants