fix: unlock update hasn't triggered after lock release #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpiatek
force-pushed
the
fix-unlock-update
branch
from
d045702 to
70e6cc8
Compare
ttypic
commented
Sep 7, 2023
src/Locks.ts
Outdated
| lock.status = 'unlocked'; | ||
| lock.reason = undefined; | ||
| // Send presence update with the updated lock, but delete afterwards so when the | ||
| // message is processed an update event is fired (the state of the ) |
There was a problem hiding this comment.
Looks like part in parenthesis hasn't completed ( and looks like without it it's clear enough :) )
added 3 commits
September 7, 2023 16:59
A lock release operation is not an error so it's confusing to have one as a reason when a lock is moved to `unlocked`. It's valid for a lock to change state and have an empty reason field for 2 main cases: - a lock has become locked without issue - a lock has becomne unlocked without issue
This ensure that if multiple connection state checks are in progress, each returns the same instance and does not create a new one.
dpiatek
force-pushed
the
fix-unlock-update
branch
from
70e6cc8 to
523b642
Compare
dpiatek
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlock update hasn't triggered after lock release
Added emitting
'update'event after lock releasedUpdate: I've updated this to a different fix. When you
geta lock, it's not valuable to getunlockedlocks - these are only useful in listeners. So the change here, which fixes the above bug, is to make sure we clear any unlocked locks, but send them in presence to process. After processing, the lock is clear. This makes the logic to compare if an event should be fired work (otherwise the mutated state is equal to the processed state and nothing happens locally).