Skip to content

Commit e6ef190

Browse files
committed
Fix 'clientId' is undefined for RealtimeMessage
`clientId` prop was made optional in ably-js v2 [1] to be consistent with the feature spec. However, spaces SDK requires `clientId` to be always set, so we can expect it to be present. [1] ably/ably-js@4e3733f
1 parent 6db9f27 commit e6ef190

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/CursorDispensing.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export default class CursorDispensing {
3636
const updates: { cursor: CursorUpdate; offset: number }[] = message.data || [];
3737

3838
updates.forEach((update: { cursor: CursorUpdate; offset: number }) => {
39-
const enhancedMsg = {
39+
const enhancedMsg: { cursor: CursorUpdate; offset: number } = {
4040
cursor: {
4141
clientId: message.clientId,
4242
connectionId: message.connectionId,

src/utilities/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export type Subset<T> = {
2828
[attr in keyof T]?: T[attr] extends object ? Subset<T[attr]> : T[attr];
2929
};
3030

31-
export type RealtimeInboundMessage = Omit<InboundMessage, 'connectionId'> & {
31+
export type RealtimeInboundMessage = Omit<InboundMessage, 'clientId' | 'connectionId'> & {
32+
clientId: string;
3233
connectionId: string;
3334
};

0 commit comments

Comments
 (0)