Commit f5be769
committed
test: make three flaky tests deterministic
Fixes the failure mechanisms behind the intermittent CI failures
observed on this PR (none of which were caused by its changes):
- browser/modular 'is able to decrypt history messages': both client-
class variants published to the same fixed channel with different
random cipher keys, so the history wait could be satisfied by the
other variant's message, which then failed to decrypt ('' !== 'Test
message'). The channel name is now unique per variant.
- uts presence_lifecycle 'bulk enterClient': members are now counted
by clientId from both 'enter' and 'present' events - a mid-test
connection blip delivers missed members via presence re-sync as
'present', so an enter-only count could undercount forever and burn
the full poll timeout. Spec pseudo updated in lock-step
(uts/realtime/integration/presence_lifecycle_test.md).
- realtime/message 'subscribes to filtered channel': the 'end'
sentinel only orders deliveries on the raw channel, but the
assertions count deliveries on the derived (filtered) channel - a
separate attachment that can lag it. A setTimeout(0) cannot bridge
that; the test now waits for the filtered deliveries (bounded at
10s within the suite's 60s budget).
The remaining presence flakes are event-driven tests with no
identifiable race; their failures are sandbox latency and are a CI
retry-policy question, not test bugs.1 parent f8789a0 commit f5be769
3 files changed
Lines changed: 50 additions & 42 deletions
File tree
- test
- browser
- realtime
- uts/realtime/integration/presence
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
555 | 555 | | |
556 | 556 | | |
557 | 557 | | |
558 | | - | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
559 | 563 | | |
560 | 564 | | |
561 | 565 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1569 | 1569 | | |
1570 | 1570 | | |
1571 | 1571 | | |
1572 | | - | |
1573 | | - | |
1574 | | - | |
1575 | | - | |
1576 | | - | |
1577 | | - | |
1578 | | - | |
1579 | | - | |
1580 | | - | |
1581 | | - | |
1582 | | - | |
1583 | | - | |
1584 | | - | |
1585 | | - | |
1586 | | - | |
1587 | | - | |
1588 | | - | |
1589 | | - | |
1590 | | - | |
1591 | | - | |
1592 | | - | |
1593 | | - | |
1594 | | - | |
1595 | | - | |
1596 | | - | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
1597 | 1598 | | |
1598 | | - | |
1599 | | - | |
1600 | | - | |
1601 | | - | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
| 1603 | + | |
| 1604 | + | |
| 1605 | + | |
| 1606 | + | |
1602 | 1607 | | |
1603 | | - | |
1604 | | - | |
1605 | | - | |
1606 | | - | |
1607 | | - | |
1608 | | - | |
| 1608 | + | |
| 1609 | + | |
1609 | 1610 | | |
1610 | 1611 | | |
1611 | 1612 | | |
| |||
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
68 | 71 | | |
69 | 72 | | |
70 | 73 | | |
| |||
74 | 77 | | |
75 | 78 | | |
76 | 79 | | |
77 | | - | |
| 80 | + | |
78 | 81 | | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
82 | | - | |
| 85 | + | |
83 | 86 | | |
84 | 87 | | |
85 | 88 | | |
| |||
0 commit comments