Merge pull request #4 from snakemode/main

check contents of hooks for data that might put errors in the console

Author: thisisjofrank

app/src/data/GitHubCommitHistory.test.ts

@@ -19,6 +19,53 @@ describe("GitHubCommitHistory", () => {
         expect(tree).toBeDefined();
     });
 
+    it("toTree, no commits in git hook, doesn't crash", () => {      
+        const hookData = gitHookWith();
+        delete hookData.commits;
+
+        sut.push(hookData);
+
+        expect(sut.toNodesAndEdges()).toBeDefined();
+    });
+
+    it("toTree, no files added in commit, doesn't crash", () => {      
+        const hookData = gitHookWith();
+        delete hookData.commits[0].added;
+
+        sut.push(hookData);
+
+        expect(sut.toNodesAndEdges()).toBeDefined();
+    });
+
+    it("toTree, no files modified in commit, doesn't crash", () => {      
+        const hookData = gitHookWith();
+        delete hookData.commits[0].modified;
+
+        sut.push(hookData);
+
+        expect(sut.toNodesAndEdges()).toBeDefined();
+    });
+
+    it("toTree, no files removed in commit, doesn't crash", () => {      
+        const hookData = gitHookWith();
+        delete hookData.commits[0].removed;
+
+        sut.push(hookData);
+
+        expect(sut.toNodesAndEdges()).toBeDefined();
+    });
+    
+    it("toTree, no repository reference in commit, doesn't crash and skips commit", () => {      
+        const hookData = gitHookWith();
+        delete hookData.repository;
+
+        sut.push(hookData);
+        const { nodes } = sut.toNodesAndEdges();
+
+        expect(nodes).toBeDefined();
+        expect([...nodes.values()].length).toBe(0);
+    });
+
     it("toTree, single file committed, node present", () => {        
         sut.push(gitHookWith(["file.txt"]));
 

app/src/data/GitHubCommitHistory.ts

@@ -25,18 +25,27 @@ export class GitHubCommitHistory {
     }
 
     private processFilePaths(message: GitHubHook) {
-        for (const commit of message.commits) {
+        const commits = message.commits || [];
+        
+        if (!message?.repository?.name) {
+            return;
+        }
+
+        for (const commit of commits) {
+            commit.added = commit.added || [];
+            commit.modified = commit.modified || [];
+            commit.removed = commit.removed || [];
+            
             this.ensureRepositoryNodeExists(message.repository.name);
 
             const touchedFiles = [...commit.added, ...commit.modified]; 
-            const deletedFiles = commit.removed || [];
 
             for (const file of touchedFiles) {
                 const id = `${message.repository.name}/${file}`;
                 this.createNodesForPath(id, message.repository.name);
             }
 
-            for (const file of deletedFiles) {
+            for (const file of commit.removed) {
                 this.deleteNodeAndEdges(`${message.repository.name}/${file}`);                
             }
         }