fs: close file descriptor of promisified truncate

joaocgreis · jasnell · commit 2073a78e0734 · 2020-07-07T06:50:28.000-07:00
PR-URL: nodejs/node#28858 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -305,7 +305,8 @@ async function rename(oldPath, newPath) {
 }
 
 async function truncate(path, len = 0) {
-  return ftruncate(await open(path, 'r+'), len);
+  const fd = await open(path, 'r+');
+  return ftruncate(fd, len).finally(fd.close.bind(fd));
 }
 
 async function ftruncate(handle, len = 0) {

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,8 @@ async function rename(oldPath, newPath) {`
`305`	`305`	`}`
`306`	`306`
`307`	`307`	`async function truncate(path, len = 0) {`
`308`		`- return ftruncate(await open(path, 'r+'), len);`
	`308`	`+ const fd = await open(path, 'r+');`
	`309`	`+ return ftruncate(fd, len).finally(fd.close.bind(fd));`
`309`	`310`	`}`
`310`	`311`
`311`	`312`	`async function ftruncate(handle, len = 0) {`