Skip to content

Commit ee14eff

Browse files
authored
Infra: Repair name of Linux PTB version (Mudlet#7221)
#### Brief overview of PR changes/additions I made an error in Mudlet#7160 as I thought that something that looked like a function call returned a value that could be assigned to something with a `set(...)` but CMake doesn't work like that, instead one has to provide a variable to recieve the value as the last argument to a `string(...)` function. 🙄 #### Motivation for adding to Mudlet Fix an error that causes cruft to appear, at least, in the version number on the first tab of the "About Mudlet" dialogue. #### Other info (issues closed, discussion etc) This should close Mudlet#7220. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
1 parent 6d7c931 commit ee14eff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ execute_process(
9696
# If a CI/CB build system provides an alternative Git SHA1 to identify the build
9797
# use that instead - reporting which is being used:
9898
if(DEFINED ENV{BUILD_COMMIT} AND NOT $ENV{BUILD_COMMIT} STREQUAL "")
99-
set(GIT_SHA1 string(TOLOWER $ENV{BUILD_COMMIT}))
99+
string(TOLOWER $ENV{BUILD_COMMIT} GIT_SHA1)
100100
message(STATUS "Git SHA1 set from environemnt: ${GIT_SHA1}")
101101
else()
102102
message(STATUS "Git SHA1 used: ${GIT_SHA1}")

0 commit comments

Comments
 (0)