[TlsInterception] v2.4.x vs v2.3.1 differences

[abhinavsingh]

• False alarm
• Closes [TlsInterception] OSError when sending empty chunk to clients under Python < 3.10 #978

[abhinavsingh]

Following works

Gen cert

$ make ca-certificates

Run proxy

$ python -m proxy --port 9000 --plugins proxy.plugin.CacheResponsesPlugin --ca-key-file ca-key.pem --ca-cert-file ca-cert.pem --ca-signing-key ca-signing-key.pem --enable-web-server --threadless
2022-01-13 16:34:21,954 - pid:23607 [I] plugins.load:85 - Loaded plugin proxy.http.proxy.HttpProxyPlugin
2022-01-13 16:34:21,955 - pid:23607 [I] plugins.load:85 - Loaded plugin proxy.http.server.HttpWebServerPlugin
2022-01-13 16:34:21,955 - pid:23607 [I] plugins.load:85 - Loaded plugin proxy.plugin.CacheResponsesPlugin
2022-01-13 16:34:21,955 - pid:23607 [I] listener.setup:97 - Listening on 127.0.0.1:9000
2022-01-13 16:34:22,011 - pid:23607 [I] pool.setup:106 - Started 16 acceptors in threadless (local) mode

2022-01-13 16:34:26,906 - pid:23614 [I] server.access_log:400 - 127.0.0.1:60346 - CONNECT httpbin.org:443 - 486 bytes - 1216.18ms
2022-01-13 16:34:26,906 - pid:23614 [I] disk.close:60 - Cached response at /var/folders/ry/tkb2qyj13qv1mdwf6z7r13l00000gn/T/httpbin.org-5-0-29.txt

Curl

$ curl -v -x localhost:9000 --cacert ca-cert.pem https://httpbin.org/get             ─╯
*   Trying ::1:9000...
* connect to ::1 port 9000 failed: Connection refused
*   Trying 127.0.0.1:9000...
* Connected to localhost (127.0.0.1) port 9000 (#0)
* allocate connect buffer!
* Establish HTTP proxy tunnel to httpbin.org:443
> CONNECT httpbin.org:443 HTTP/1.1
> Host: httpbin.org:443
> User-Agent: curl/7.77.0
> Proxy-Connection: Keep-Alive
> 
< HTTP/1.1 200 Connection established
< 
* Proxy replied 200 to CONNECT request
* CONNECT phase completed!
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: ca-cert.pem
*  CApath: none
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: CN=httpbin.org
*  start date: Jan 13 11:03:03 2022 GMT
*  expire date: Jan 13 11:03:03 2024 GMT
*  subjectAltName: host "httpbin.org" matched cert's "httpbin.org"
*  issuer: CN=example.com
*  SSL certificate verify ok.
> GET /get HTTP/1.1
> Host: httpbin.org
> User-Agent: curl/7.77.0
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Date: Thu, 13 Jan 2022 11:04:26 GMT
< Content-Type: application/json
< Content-Length: 256
< Connection: keep-alive
< Server: gunicorn/19.9.0
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Credentials: true
< 
{
  "args": {}, 
  "headers": {
    "Accept": "*/*", 
    "Host": "httpbin.org", 
    "User-Agent": "curl/7.77.0", 
    "X-Amzn-Trace-Id": "Root=1-61e0073a-6fdb4457650af7fd2ac13448"
  }, 
  "origin": "106.202.255.39", 
  "url": "https://httpbin.org/get"
}
* Connection #0 to host localhost left intact

[codecov]

Codecov Report

Merging #979 (1989085) into develop (dd2476f) will decrease coverage by 0.18%.
The diff coverage is 38.46%.

@@             Coverage Diff             @@
##           develop     #979      +/-   ##
===========================================
- Coverage    85.90%   85.72%   -0.19%     
===========================================
  Files          145      145              
  Lines         6252     6257       +5     
  Branches       636      639       +3     
===========================================
- Hits          5371     5364       -7     
- Misses         758      769      +11     
- Partials       123      124       +1     

Flag	Coverage Δ
pytest	85.58% <38.46%> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
proxy/core/work/remote.py	96.42% <ø> (ø)
proxy/core/work/pool.py	88.52% <33.33%> (-3.15%)	⬇️
proxy/core/work/threaded.py	75.00% <33.33%> (-11.67%)	⬇️
proxy/core/work/threadless.py	79.16% <42.85%> (-1.59%)	⬇️
proxy/core/base/tcp_server.py	84.48% <0.00%> (-1.73%)	⬇️
proxy/http/handler.py	72.84% <0.00%> (-1.30%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2476f...1989085. Read the comment docs.