Skip to content

Commit 9453df0

Browse files
committed
Is threaded an issue with TLS interception?
1 parent 34198d4 commit 9453df0

File tree

1 file changed

+20
-19
lines changed

1 file changed

+20
-19
lines changed

tests/integration/test_integration.py

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@
4848
'--threadless --local-executor 0 --plugin proxy.plugin.ModifyChunkResponsePlugin ' +
4949
TLS_INTERCEPTION_FLAGS
5050
),
51-
(
52-
'--threaded --plugin proxy.plugin.ModifyChunkResponsePlugin ' +
53-
TLS_INTERCEPTION_FLAGS
54-
),
51+
# (
52+
# '--threaded --plugin proxy.plugin.ModifyChunkResponsePlugin ' +
53+
# TLS_INTERCEPTION_FLAGS
54+
# ),
5555
)
5656

5757
PROXY_PY_FLAGS_MODIFY_POST_DATA_PLUGIN = (
@@ -101,6 +101,7 @@ def proxy_py_subprocess(request: Any) -> Generator[int, None, None]:
101101
'--num-acceptors', '3',
102102
'--num-workers', '3',
103103
'--ca-cert-dir', str(ca_cert_dir),
104+
'--log-level', 'd',
104105
) + tuple(request.param.split())
105106
proxy_proc = Popen(proxy_cmd)
106107
# Needed because port file might not be available immediately
@@ -168,18 +169,18 @@ def test_modify_chunk_response_integration(proxy_py_subprocess: int) -> None:
168169
check_output([str(shell_script_test), str(proxy_py_subprocess)])
169170

170171

171-
# @pytest.mark.smoke # type: ignore[misc]
172-
# @pytest.mark.parametrize(
173-
# 'proxy_py_subprocess',
174-
# PROXY_PY_FLAGS_MODIFY_POST_DATA_PLUGIN,
175-
# indirect=True,
176-
# ) # type: ignore[misc]
177-
# @pytest.mark.skipif(
178-
# IS_WINDOWS,
179-
# reason='OSError: [WinError 193] %1 is not a valid Win32 application',
180-
# ) # type: ignore[misc]
181-
# def test_modify_post_response_integration(proxy_py_subprocess: int) -> None:
182-
# """An acceptance test for :py:class:`~proxy.plugin.ModifyPostDataPlugin`
183-
# interception using ``curl`` through proxy.py."""
184-
# shell_script_test = Path(__file__).parent / 'test_modify_post_data.sh'
185-
# check_output([str(shell_script_test), str(proxy_py_subprocess)])
172+
@pytest.mark.smoke # type: ignore[misc]
173+
@pytest.mark.parametrize(
174+
'proxy_py_subprocess',
175+
PROXY_PY_FLAGS_MODIFY_POST_DATA_PLUGIN,
176+
indirect=True,
177+
) # type: ignore[misc]
178+
@pytest.mark.skipif(
179+
IS_WINDOWS,
180+
reason='OSError: [WinError 193] %1 is not a valid Win32 application',
181+
) # type: ignore[misc]
182+
def test_modify_post_response_integration(proxy_py_subprocess: int) -> None:
183+
"""An acceptance test for :py:class:`~proxy.plugin.ModifyPostDataPlugin`
184+
interception using ``curl`` through proxy.py."""
185+
shell_script_test = Path(__file__).parent / 'test_modify_post_data.sh'
186+
check_output([str(shell_script_test), str(proxy_py_subprocess)])

0 commit comments

Comments
 (0)