chore(kong): BindToProvider singletons workaround #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BindToProvider in Kong will create new instances of bindings that come from a provider function every time they're requested by another binding. This means that we always re-open some of these resources multiple times: e.g. repository is opened when requested by state.Store, by spice.Service, and then by individual commands. Work around this with a sync.Once until the new [BindSingletonProvider option](alecthomas/kong#501) is released.
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BindToProvider in Kong will create new instances of bindings
that come from a provider function every time they're requested
by another binding.
This means that we always re-open some of these resources
multiple times: e.g. repository is opened when requested by state.Store,
by spice.Service, and then by individual commands.
Work around this with a sync.Once until the new
BindSingletonProvider option
is released.