Turbopack: fix another case of edge runtime warnings (vercel#70455)

Closes PACK-3276

Author: mischnic

crates/next-custom-transforms/src/transforms/warn_for_edge_runtime.rs

@@ -298,10 +298,16 @@ impl Visit for WarnForEdgeRuntime {
     fn visit_bin_expr(&mut self, node: &BinExpr) {
         match node.op {
             op!("&&") | op!("||") | op!("??") => {
-                self.with_new_scope(move |this| {
-                    this.add_guards(&node.left);
-                    node.right.visit_with(this);
-                });
+                if self.should_add_guards {
+                    // This is a condition and not a shorthand for if-then
+                    self.add_guards(&node.left);
+                    node.right.visit_with(self);
+                } else {
+                    self.with_new_scope(move |this| {
+                        this.add_guards(&node.left);
+                        node.right.visit_with(this);
+                    });
+                }
             }
             op!("==") | op!("===") => {
                 self.add_guard_for_test(&node.left);

crates/next-custom-transforms/tests/fixture/edge-assert/guarded-process/input.js

@@ -1,3 +1,8 @@
 if (typeof process.loadEnvFile === 'function') {
   console.log(process.loadEnvFile())
 }
+
+typeof process < 'u' &&
+  typeof process.off == 'function' &&
+  (process.off('uncaughtException', this.onUncaughtException),
+  process.off('unhandledRejection', this.onUncaughtRejection))

crates/next-custom-transforms/tests/fixture/edge-assert/guarded-process/output.js

@@ -1,3 +1,4 @@
 if (typeof process.loadEnvFile === 'function') {
     console.log(process.loadEnvFile());
 }
+typeof process < 'u' && typeof process.off == 'function' && (process.off('uncaughtException', this.onUncaughtException), process.off('unhandledRejection', this.onUncaughtRejection));