-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix viewer crash with empty layers #339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
===========================================
+ Coverage 0 92.35% +92.35%
===========================================
Files 0 50 +50
Lines 0 3989 +3989
Branches 0 522 +522
===========================================
+ Hits 0 3684 +3684
- Misses 0 203 +203
- Partials 0 102 +102
Continue to review full report at Codecov.
|
@cbmoore May I ask if this PR fixes the issue? (I'm still struggling with Monterey/M1 issues at the moment) Use the following command to install from this branch: pip install -U git+https://github.com/abey79/vpype@fix-empty-layer-crash-338#egg=vpype[all] |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@abey79 Sorry it took me so long to get back to you--looks like you already tested and merged but if there's anything else I can do to be helpful. Thanks for addressing this issue so quickly. |
@cbmoore No worries. Reporting issues is already very helpful! |
Description
The viewer crashes when presented with empty layers (eg due to crop).
Fixes #338
Checklist
black
andisort
)mypy vpype vpype_cli tests
returns no errorpytest
succeedshelp
make clean && make html
indocs/
)