Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with Click 8.0 #273

Closed
vmario89 opened this issue May 17, 2021 · 5 comments · Fixed by #282
Closed

Fix crash with Click 8.0 #273

vmario89 opened this issue May 17, 2021 · 5 comments · Fixed by #282

Comments

@vmario89
Copy link

Hi,
i updated some of my pip modules. Now i get the following warnings:

/home/tomate/.local/lib/python3.8/site-packages/vpype_cli/cli.py:126: DeprecationWarning: 'resultcallback' has been renamed to 'result_callback'. The old name will be removed in Click 8.1.
  @cli.resultcallback()
/home/tomate/.local/lib/python3.8/site-packages/vpype_cli/cli.py:108: DeprecationWarning: 'get_os_args' is deprecated and will be removed in Click 8.1. Access 'sys.argv[1:]' directly instead.
  cmd_string = "vpype " + " ".join(shlex.quote(arg) for arg in get_os_args()) + "\n"
Error in vpype:'int' object has no attribute 'lower'
@abey79
Copy link
Owner

abey79 commented May 17, 2021

Thanks for reporting. Indeed, Click has released a new major version and there might be some change I need to do for compatibility.

@abey79 abey79 changed the title Deprecation warnings Fix deprecation warning related to Click 8.0 May 17, 2021
@abey79 abey79 changed the title Fix deprecation warning related to Click 8.0 Fix deprecation warnings related to Click 8.0 May 17, 2021
@abey79
Copy link
Owner

abey79 commented May 18, 2021

I can't directly reproduce this error, can you provide the full command which triggers it?

@vmario89
Copy link
Author

Hi. They are thrown when running https://gitea.fablabchemnitz.de/MarioVoigt/mightyscape-1.X/src/branch/master/extensions/fablabchemnitz/vpypetools/vpypetools.py from an inkscape extension call, like linesort

grafik

@abey79 abey79 changed the title Fix deprecation warnings related to Click 8.0 Fix crash with Click 8.0 May 18, 2021
@abey79
Copy link
Owner

abey79 commented May 18, 2021

I can reproduce now, and I see that it's actually a crash in addition to deprecation warnings. Working on it.

@abey79
Copy link
Owner

abey79 commented May 18, 2021

The workaround it to use a pre-8 version of Click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants