Skip to content

Commit aae2b60

Browse files
committed
fix(dropdown): fix ref validation
1 parent 85c3a0a commit aae2b60

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

packages/components/base/src/dropdown/Dropdown.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,13 @@ export const Dropdown = ({
130130
setInternalOpen(open);
131131
}, [open]);
132132

133+
useEffect(() => {
134+
if (!internalOpen) return;
135+
if (!anchorRef.current) {
136+
throw new Error("Dropdown anchor ref not initialized");
137+
}
138+
}, [anchorRef, internalOpen]);
139+
133140
return (
134141
internalOpen && (
135142
<PositionEngine

packages/components/base/src/dropdown/DropdownButton.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,6 @@ export const DropdownButton: React.FC<Readonly<DropdownButtonProps>> = ({
6868
setInternalOpen(open);
6969
}, [open]);
7070

71-
useEffect(() => {
72-
if (buttonRef.current) {
73-
throw new Error("DropdownButton ref not initialized");
74-
}
75-
}, []);
76-
7771
return (
7872
<>
7973
{button}

0 commit comments

Comments
 (0)