fix(dropdown): do not click menuitem again (#39)

Author: abeidahmed

CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
 
+### Fixed
+
+- Do not click menuitem again
+
 ## [0.3.1] - 2024-04-26
 
 ### Fixed

packages/core/src/elements/dropdown/index.ts

@@ -255,7 +255,6 @@ export default class DropdownElement extends ImpulseElement {
     }
     // Click the active menu item.
     if (this.menuItemActive(menuItem)) {
-      menuItem.click();
       this.open = false;
       this.trigger.focus();
       this.emit('changed', { detail: { relatedTarget: menuItem } });

packages/playground/src/pages/dropdown/dropdown.vue

@@ -1,5 +1,9 @@
 <script setup lang="ts">
 import GdButton from '../../components/button.vue';
+
+function notify(message: string) {
+  alert(message);
+}
 </script>
 
 <template>
@@ -15,6 +19,7 @@ import GdButton from '../../components/button.vue';
             type="button"
             data-target="twc-dropdown.menuItems"
             class="text-gray-900 group flex w-full items-center rounded px-2 py-2 text-sm ui-active:bg-gray-100 disabled:text-gray-400"
+            @click="notify('You clicked on Edit')"
           >
             Edit
           </button>