change(floating-panel): default strategy to fixed (#33)

Author: abeidahmed

CHANGELOG.md

@@ -12,6 +12,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Support arrow in Floating panel element
 - Allow trigger id to be set in the Floating panel element
 
+### Changed
+
+- Set Floating Panel element's default strategy to "fixed"
+
 ## [0.2.0] - 2024-01-14
 
 ### Added

packages/core/src/elements/floating_panel/README.md

@@ -49,11 +49,11 @@ For more info, visit the [official docs](https://floating-ui.com/docs/computePos
 
 ### Setting the positioning strategy
 
-By default, the positioning strategy is set as `absolute`, but you can set it to one of `absolute` or `fixed` by
+By default, the positioning strategy is set as `fixed`, but you can set it to one of `absolute` or `fixed` by
 setting the `strategy` attribute on the element.
 
 ```html
-<twc-floating-panel strategy="fixed">
+<twc-floating-panel strategy="absolute">
   ...
 </twc-floating-panel>
 ```

packages/core/src/elements/floating_panel/index.test.ts

@@ -22,7 +22,7 @@ describe('Floating panel', () => {
     await waitUntil(() => el.hasAttribute('data-current-placement'));
     expect(el).to.have.attribute('data-current-placement', 'bottom-start');
     expect(panel).to.have.attribute('data-current-placement', 'bottom-start');
-    expect(panel).to.have.style('position', 'absolute');
+    expect(panel).to.have.style('position', 'fixed');
 
     el.active = false;
     expect(el).not.to.have.attribute('active');

packages/core/src/elements/floating_panel/index.ts

@@ -39,7 +39,7 @@ export default class FloatingPanelElement extends ImpulseElement {
    * One of 'absolute' or 'fixed'.
    * https://floating-ui.com/docs/computeposition#strategy
    */
-  @property() strategy: Strategy = 'absolute';
+  @property() strategy: Strategy = 'fixed';
 
   /**
    * The initial position of the panel. This placement can be changed to keep the panel within the viewport.