add transaction commit fail test

Author: taochen

dal-client/src/test/java/com/ctrip/platform/dal/dao/client/DatabaseCategory/CustomConnection.java renamed to dal-client/src/test/java/com/ctrip/platform/dal/dao/client/CustomConnection.java

@@ -1,4 +1,4 @@
-package com.ctrip.platform.dal.dao.client.DatabaseCategory;
+package com.ctrip.platform.dal.dao.client;
 
 import java.sql.*;
 import java.util.Map;

dal-client/src/test/java/com/ctrip/platform/dal/dao/client/CustomDalConnectionManager.java

@@ -0,0 +1,22 @@
+package com.ctrip.platform.dal.dao.client;
+
+import com.ctrip.platform.dal.dao.DalEventEnum;
+import com.ctrip.platform.dal.dao.DalHints;
+import com.ctrip.platform.dal.dao.configure.DalConfigure;
+
+import java.sql.SQLException;
+
+/**
+ * Created by taochen on 2019/10/23.
+ */
+public class CustomDalConnectionManager extends DalConnectionManager {
+    public CustomDalConnectionManager(String logicDbName, DalConfigure config) {
+        super(logicDbName, config);
+    }
+
+    @Override
+    public DalConnection getNewConnection(DalHints hints, boolean useMaster, DalEventEnum operation)
+            throws SQLException {
+        return new DalConnection(new CustomConnection(), true, null, super.getNewConnection(hints, useMaster, operation).getMeta());
+    }
+}

dal-client/src/test/java/com/ctrip/platform/dal/dao/client/DalTransactionManagerTest.java

@@ -1,6 +1,7 @@
 package com.ctrip.platform.dal.dao.client;
 
 import com.ctrip.platform.dal.dao.*;
+import com.ctrip.platform.dal.exceptions.TransactionSystemException;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -24,6 +25,10 @@ public class DalTransactionManagerTest {
 	private static DalConnectionManager getDalConnectionManager() throws Exception {
 		return new DalConnectionManager(logicDbName, DalClientFactory.getDalConfigure());
 	}
+
+	private static CustomDalConnectionManager getCustomDalConnectionManager() throws Exception {
+		return new CustomDalConnectionManager(logicDbName, DalClientFactory.getDalConfigure());
+	}
 
 	@Test
 	public void testDalTransactionManager() {
@@ -184,6 +189,26 @@ public Object execute() throws Exception {
 		}
 	}
 
+	@Test
+	public void testDoInTransactionCommitFail() {
+		final DalHints hints = new DalHints();
+		try {
+			final DalTransactionManager test = new DalTransactionManager(getCustomDalConnectionManager());
+			ConnectionAction<?> action = new ConnectionAction<Object>() {
+				public Object execute(){
+					return new Object();
+				}
+			};
+			test.doInTransaction(action, hints);
+			fail();
+		} catch (Exception e) {
+		    e.printStackTrace();
+            if (!(e instanceof TransactionSystemException)) {
+                fail();
+            }
+		}
+	}
+
 	@Test
 	public void testRegister() {
 		final DalHints hints = new DalHints();

dal-client/src/test/java/com/ctrip/platform/dal/dao/client/DalTransactionTest.java

@@ -1,7 +1,6 @@
 package com.ctrip.platform.dal.dao.client;
 
 import com.ctrip.platform.dal.dao.DalClientFactory;
-import com.ctrip.platform.dal.dao.client.DatabaseCategory.CustomConnection;
 import com.ctrip.platform.dal.exceptions.TransactionSystemException;
 import org.junit.*;
 import com.ctrip.platform.dal.dao.task.SqlServerTestInitializer;