✨ Refactor and Improve all incentives #2308
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@MartinGbz is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
…e it from the asset name
MartinGbz
changed the title
| @@ -150,5 +150,6 @@ | |||
| "budget": null, | |||
| "budgetPercentIncreaseRed": 20, | |||
| "showDetails": true | |||
| } | |||
| }, | |||
| "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | |||
There was a problem hiding this comment.
I think we can omit this. Try running corepack disable
| <Trans>Participating in this {symbol} reserve gives annualized rewards.</Trans> | ||
| <Trans> | ||
| Participating in this {symbol} reserve gives additional annualized rewards through Aave | ||
| Liquidity Mining |
There was a problem hiding this comment.
I think lets remove the "Liquidity Mining"
|
|
||
| import { Link } from '../primitives/Link'; | ||
|
|
||
| export const EthenaAirdropTooltipContent = ({ points }: { points: number }) => { |
There was a problem hiding this comment.
This file can probably be optimized into one component if it continues to grow. As its all the same except for the text and the link i think right?
| }; | ||
|
|
||
| const multipleIncentives = allAprsIncentivesCount >= 2; | ||
| const singleIncentives = allIncentivesCount >= 1; |
| textAlign: 'center', | ||
| }} | ||
| > | ||
| {value.toString() !== '-1' ? ( |
There was a problem hiding this comment.
What is this -1 representing? Can we label it as a variable for readability
| import { Link } from '../primitives/Link'; | ||
| import { TextWithTooltip } from '../TextWithTooltip'; | ||
|
|
||
| export const SuperFestTooltip = () => { |
There was a problem hiding this comment.
Same here these can be extracted into a component i think all the logic and text is the same.
|
❌ CI run has failed! |
General Changes
This PR adds all the incentives (lm, merit, zksync ignite) on all remaining, ie:
It also add 2 new compoenent for:
This allows to centralized every points/external incentives display at the same place.
I also now specify the chain in the key of Set/Map for these component, because it can happen sometimes that different tokens can have the same address (Example: aAvaSAvax === aArbWstETH). So this prevent from this issue.
It also adds a new component that batch incentives APRs when multiple (2 or more) are available for an asset. This new component display the sum of all the incentives APRs. I decided to only batch APRs incentives and not points & "external simple incentives" in order to highlight them way better (so you have: the aprs, the points, and the others). This means the maximum number of tooltips we can expected below the Supply/Borrow rate will be 3 (which I think is acceptable).
It also fix 3 issues:
It also fix the forum post link of Sonic USDC.e Merit incentives
You can test all the cases on all Modals/Infos by mocking API returns.
Here's a few screenshots of the preview (I added a Merit incentive on USDS supply + borrow, and a ZKSync Ignite incentives on USDS supply):
Markets (showcase the new apr batched tooltip unfolded):
Supply Info:
Switch Supply Modal:
Switch Debt Modal:
Supply Modal:
Borrow Modal:
Developer Notes
Created a new
IncentivesBoxcomponent that can be used everywhere in the app.So we only need to define any new incentive type in this component, and it will be display everywhere else.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files