Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor initial foundry tests #324

Merged

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2023

Will close #321 .

Removes GhoActions/TestEnv, creates a common TestGhoBase, separates errors/imports, removes unneeded imports from individual tests, cleans up some tests to use appropriate globals.

@height
Copy link

height bot commented May 1, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@ghost ghost marked this pull request as ready for review May 2, 2023 21:33
@ghost ghost requested review from miguelmtzinf, foodaka, Zer0dot and The-3D as code owners May 2, 2023 21:33
@ghost ghost merged commit e4c6aa5 into feat/319-additional-foundry-test-coverage May 4, 2023
@miguelmtzinf miguelmtzinf deleted the fix/321-refactor-foundry-tests branch June 2, 2023 08:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants