Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 suggestions #116

Open
sakulstra opened this issue Mar 8, 2021 · 0 comments
Open

v3 suggestions #116

sakulstra opened this issue Mar 8, 2021 · 0 comments

Comments

@sakulstra
Copy link
Contributor

sakulstra commented Mar 8, 2021

I thought it makes sense to collect some things we might wanna fix in a potential v3 so that we can batch some breaking changes.

Dedicated entry points

We currently got a single entry point exporting {...v2, ...common, v1, v2} we do that because the library has historically grown and tsdx doesn't support multiple entry points.
In the future though it would be nice if we could offer entrypoints for v1/v2/common instead.

https://github.com/developit/microbundle

Flat input types

Our current functions are very much tied to the graphql types. While that makes sense in most occasions a lot of people have problems using this library as they don't necessarily use the graphql data.

Better comment & descriptions

We get a lot of issues reported via discord/telegram and so on, where people are confused about e.g. what format they have to provide for usdPriceEth. Would be nice if we would display examples for these things inside the editor.

Less type conversions

BigNumberValue sounds like a good idea ux wise but isn't necessarily one perf wise. We do a lot of unnecessary bignumber constructs. Might make sense to look into having explicit types. Or optimize our functions to reuse BigNumbers instead of recreating them.

drop axios

we should use sth like isomorphic fetch as axios is quite fat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant