Port to .NET Standard #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
conniey
reviewed
May 9, 2017
| // | ||
| // You can specify all the values or you can default the Revision and Build Numbers | ||
| // by using the '*' as shown below: | ||
| [assembly: AssemblyVersion("4.1.1.0")] |
There was a problem hiding this comment.
I am not sure if you meant to check this in since it's always updated during testing. :)
conniey
reviewed
May 9, 2017
| [InlineData("F", "ko-KR", "2017년 1월 13일 금요일 오전 5:32:06")] | ||
| [InlineData("g", "ko-KR", "2017-01-13 오전 5:32")] | ||
| [InlineData("G", "ko-KR", "2017-01-13 오전 5:32:06")] | ||
| // [InlineData("f", "ko-KR", "2017년 1월 13일 금요일 오전 5:32")] |
There was a problem hiding this comment.
I tried to look into these failures because the tests work on Windows but not Linux. From what I could tell, Mono is having troubles trying to fetch the AM/PM designator for ko-KR (because it is always null).
There was a problem hiding this comment.
I left a comment to @justinyoo , who contributed this code. Maybe he knows more about this problem.
|
LGTM. 👍 Thanks a lot for putting this together! |
Merged
…TSTANDARD1_3 as a friend assembly
…hers run their associated builds.
…DotNetStandard configuration
…ferences between platforms
To ensure consistency between the 'Run-Unit-Tests' and 'Test-Release-Configurations' targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all the changes proposed and discussed in #244.
What's included:
Release-DotNetStandard-UnsignedandRelease-DotNetStandard-Signedthat produce assemblies targetingnetstandard1.3.netstandard1.3assemblies to the Nuget packages. This means that using YamlDotNet on .NET core should no longer be a problem.aaubry/yamldotnet) that contains all the dependencies needed to build YamlDotNet on Linux. This was necessary to overcome some difficulties with mono, but it is also useful for anyone wanting to build the library without having to install anything (besides Docker).What's still missing: