-
Notifications
You must be signed in to change notification settings - Fork 18
Allow reconciliation if single dataset is missing snapshots #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If you do like this, you'll have to adjust the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I'm good with this if we can make existing tests pass - meaning it doesn't alter existing expectations and is a non-breaking change. It may be time to move snapshot validation out into it's own function.
I've merged the loops. This is working with the following tests Run the script a few times. I had to change the loop to loop through the source snaps as opposed to the destination snaps. This is because the source is the authoritative side of the set. |
I'm now soring snaps in reverse as the I tried to see what you were doing with the tests, but can't seem to figure it out quite. |
Been running this now over a couple days, doing cloning, send/recv etc... Works great. |
#53