Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aarongustafson/jekyll-webmention_io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.0
Choose a base ref
...
head repository: aarongustafson/jekyll-webmention_io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 11 commits
  • 17 files changed
  • 2 contributors

Commits on Jul 6, 2023

  1. Fix layout sample issue

    Darn liquid template tags...
    fancypantalons authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4c95f8b View commit details
    Browse the repository at this point in the history
  2. More liquid tag cleanup

    Found another one...
    fancypantalons authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    42b1734 View commit details
    Browse the repository at this point in the history
  3. Fix bug in Jekyll defaults example

    Silly typo...
    fancypantalons authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    dfa1471 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    386417d View commit details
    Browse the repository at this point in the history
  2. feat: Add cross-platform editor configuration

    Allows editing in most modern editors according to the project defaults
    without manual configuration.
    l0b0 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    47bb31e View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge pull request #173 from l0b0/feat/editor-config

    Add cross-platform editor configuration
    fancypantalons authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    c8b2f2f View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Rework of webmention templates

    This commit is intended to address issues #175, #176, and #177.  It is a
    fairly involved reworking of these templates that standardizes the
    layout and, I hope, does a better job of rendering h-card information
    for posts and so forth.
    
    These changes introduce some structural changes to the HTML, including
    consistently embedding webmention content in article tags, and
    repositioning some of the relevant classes.
    
    Any users of the default templates will want to inspect these changes
    and make corresponding changes to their CSS.
    
    Now, I have to admit, the sheer amount of code duplication across these
    templates fills me with sadness, but because of the need to support both
    client- and server-side template rendering, these things kinda need to
    stand on their own.  I did explore the use of custom filters to render
    blocks like the h-card using their own templates, but figuring out how
    to make a custom filter on the JS side, not to mention testing it, was
    beyond my ken.
    fancypantalons committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    63559f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Implement html_proofer_ignore setting

    This changeset is intended to address issue #172.  It introduces a new
    html_proofer_ignore setting which can take the values "templates" or
    "all".  When set to "templates", the behaviour is equivalent to setting
    the html_proofer setting to true.  When set to "all", in addition to
    that original behaviour, the included webmention templates will add the
    data-proofer-ignore attribute to the rendered webmention output, which
    will cause any content sent via webmention to be ignored by the proofer.
    fancypantalons committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e367500 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Wow... equal sign error?

    Yup, haven't made a mistake like this in years.  Maybe Pascal had it
    right to make assignment a special operator...
    fancypantalons committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    aed2a46 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Reject malformed URIs during gather phase

    This commit addresses issue #178 by adding an additional check during
    the URI gathering phase such that, after the initial regex match finds a
    URI, we attempt to parse that URI.  If that fails, we ignore the URI as
    a spurious match and move on.
    
    This is, of course, a hack.  In practice we should clean up that regex
    so that bad matches don't happen.  But, since I don't know enough about
    the history of that regex, and because that could turn into a game of
    whack-a-mole, I went this route.  And, ultimately, this is just more
    bullet-proof.
    
    Note, these events are silently ignored at the regular logging level.
    However, at debug level, a log message is emitted indicating a URI was
    skipped.
    fancypantalons committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    fc01029 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Always set_data when calling render_into_template

    This commit fixes issue #179. The method `set_data` sets the class
    instance variable @DaTa with essential state information needed during
    the render call.
    
    However, as this tag is instantiated during the creation of a template,
    its instance persists if the template is rendered multiple times. So if
    a page is rendered with this template, and that page contains
    webmentions, and then a subsequent page is rendered that has no
    webmentions, if that state isn't cleared out, then it's erroneously used
    in that subsequent call.
    
    Well, prior to this changeset, the `set_data` method was only called if
    webmentions were available for a given page. That meant pages without
    any webmentions failed to clear the previously cached state, and the
    webmentions would end up re-rendered in the current page.
    
    This changeset modifies this method (and cleans up the ordering of the
    code a bit) so that the state is always populated, regardless of the
    presence of webmentions on the page. This ensures the @DaTa variable
    always contains the state for the current page being rendered, even if
    that state includes an empty list of webmentions.
    fancypantalons committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7d14638 View commit details
    Browse the repository at this point in the history
Loading