Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/552 ekfac bug mps osx #578

Merged
merged 6 commits into from
May 7, 2024
Merged

Fix/552 ekfac bug mps osx #578

merged 6 commits into from
May 7, 2024

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented May 6, 2024

Description

This PR closes #552

Changes

  • add a decorator to catch exceptions of a specific type and raise a more concrete exception type
  • add TorchLinalgEighException
  • add safe_torch_linalg_eigh which is decorated to raise the above exception, if a RunTimeError occurs in calling torch.linalg.eigh
  • add tests, where the exception testing is only pulled out on osx-arm64

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@schroedk schroedk marked this pull request as ready for review May 6, 2024 15:37
@schroedk schroedk added this to the v0.9.2 milestone May 6, 2024
janosg
janosg previously approved these changes May 6, 2024
Copy link
Collaborator

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@schroedk schroedk force-pushed the fix/552-ekfac-bug-mps-osx branch from 8f6a2c7 to 97b09df Compare May 7, 2024 08:41
@schroedk schroedk merged commit 8e211dc into develop May 7, 2024
35 checks passed
@schroedk schroedk deleted the fix/552-ekfac-bug-mps-osx branch May 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EkfacInfluence breaks for large LinearLayer
2 participants