-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements to OOB notebook #431
Conversation
@BastienZim I've worked a bit on your notebook, let me know if you have comments. I was a bit surprised by the very different results that one can obtain with different seeds, often obtaining a degradation of performance with the removal of the worst 20% points. In the end I added complete randomization of the whole run including the splitting of the dataset to see what the true variance is. It is a lot more, but things are predictable. I also added random seed handling to compute_oob and did a couple minor things here and there |
Co-authored-by: Anes Benmerzoug <a.benmerzoug@appliedai.de>
Co-authored-by: Anes Benmerzoug <a.benmerzoug@appliedai.de>
# Conflicts: # docs/value/index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It's only missing a changelog entry.
Description
This PR adds some text and supporting functions to the OOB notebook.
Changes
compute_data_oob
oob.py
I also sneaked in a couple of unrelated things:
Checklist
"tags": ["hide"]
or"tags": ["hide-input"]