Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to OOB notebook #431

Merged
merged 19 commits into from
Sep 20, 2023
Merged

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Sep 15, 2023

Description

This PR adds some text and supporting functions to the OOB notebook.

Changes

  • Moves data prep to the supporting module
  • Adds a method to draw confidence intervals (normal and t)
  • Redoes a couple of plots using it
  • Adds random seed handling to compute_data_oob
  • Ensures reproducibility of the notebook by passing around the seed
  • Does some minor renaming in oob.py

I also sneaked in a couple of unrelated things:

  • An adjustment of font sizes in the api docs
  • Minor cosmetic changes here and there

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito
Copy link
Collaborator Author

mdbenito commented Sep 18, 2023

@BastienZim I've worked a bit on your notebook, let me know if you have comments. I was a bit surprised by the very different results that one can obtain with different seeds, often obtaining a degradation of performance with the removal of the worst 20% points. In the end I added complete randomization of the whole run including the splitting of the dataset to see what the true variance is. It is a lot more, but things are predictable. I also added random seed handling to compute_oob and did a couple minor things here and there

@mdbenito mdbenito marked this pull request as ready for review September 18, 2023 08:21
@mdbenito mdbenito self-assigned this Sep 18, 2023
@mdbenito mdbenito added enhancement New feature or request documentation Improvements or additions to documentation and removed enhancement New feature or request labels Sep 18, 2023
@mdbenito mdbenito added this to the v0.7.1 milestone Sep 18, 2023
Co-authored-by: Anes Benmerzoug <a.benmerzoug@appliedai.de>
mdbenito and others added 3 commits September 18, 2023 19:52
Co-authored-by: Anes Benmerzoug <a.benmerzoug@appliedai.de>
# Conflicts:
#	docs/value/index.md
AnesBenmerzoug
AnesBenmerzoug previously approved these changes Sep 18, 2023
Copy link
Collaborator

@AnesBenmerzoug AnesBenmerzoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's only missing a changelog entry.

@mdbenito mdbenito merged commit 43690b0 into develop Sep 20, 2023
@mdbenito mdbenito deleted the doc/improve-oob-notebook branch September 20, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants