Fix ReDoS issue #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pclinger , |
|
Hello @aMarCruz, please let me know if you have any questions about this PR. Thank you! |
|
Hello @aMarCruz just following up on this one. Thank you |
|
Hello again @aMarCruz, just wanted to followup on this PR if you can review & merge. |
|
Hello @aMarCruz, just wanted to followup on this fix. Please let me know if there is anything I can do to help get this merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There is a Regex Denial of Service (ReDoS) that this PR fixes.
(?:\\.|[^\]\\]*)*can be simplified to(?:\\.|[^\]\\])*which resolves the issue.You can check the original and updated regex using this ReDoS checker:
original:
/^\/(?=[^*/])[^[/\\]*(?:(?:\\.|\[(?:\\.|[^\]\\]*)*\])[^[\\/]*)*?\/[gimuys]*/fixed:
/^\/(?=[^*/])[^[/\\]*(?:(?:\\.|\[(?:\\.|[^\]\\])*\])[^[\\/]*)*?\/[gimuys]*/Example that causes the problem:
/^\/(?=[^*/])[^[/\\]*(?:(?:\\.|\[(?:\\.|[^\]\\]*)*\])[^[\\/]*)*?\/[gimuys]*/.test('/[[/g][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][gg][g')Thank you for your consideration.