-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Autolinking for React Native 0.69 #39
base: master
Are you sure you want to change the base?
Conversation
@aMarCruz I saw your difficulties in maintaining the project. But, could you please just approve this fix? I believe it is very important to keep the library on the radar. |
@aMarCruz I tested it! This works like a glove. I'm willing to take care of the package if it helps. This commit is really too important to merge. I will create a fork and a temporary npm for this to be live. Can we please merge this? I appreciate your effort ever since. Take me into consideration if you need anything. |
Thanks a lot — this also makes the library work again with Expo EAS (SDK 46)! @aMarCruz I'd also be willing to take over your library if needed, if @yepMad can't for some reason. One of our projects heavily depends on it to conform to layout/styling requirements. Thanks for your work on this - it's helped a ton! |
@mfkrause How did you get it to work with Expo? Was it by using a development build (https://docs.expo.dev/development/create-development-builds/)? |
Yes, you need to use a development build for stuff like this. |
Fixes #38
Moved podspec file to root directory, as the podspec file needs to be in root directory in order for autolinking to work in react-native/cli v8