Update where.js #88
Open
Update where.js #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,9 @@ angular.module('a8m.where', []) | |||
| .filter('where', function() { | |||
| return function (collection, object) { | |||
|
|
|||
| if(isUndefined(collection)) { | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
@rodolfojnn why not add this test to the same if below?
There was a problem hiding this comment.
Because the return is different in each case. So I thought better to separate them.
There was a problem hiding this comment.
I think the return value should be consistent with the other filters, e.g: groupBy, uniq, etc..
also it will be great if you add test for this too.
thx @rodolfojnn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #87
Thx