Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin notebook version <7 #371 #372

Merged
merged 8 commits into from
Mar 31, 2024
Merged

pin notebook version <7 #371 #372

merged 8 commits into from
Mar 31, 2024

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Mar 12, 2024

Reference Issues/PRs

#371

Pins Jupyternotebook to version <7 for compatibility with extensions.

What does this implement/fix? Explain your changes

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

@a-r-j
Copy link
Owner Author

a-r-j commented Mar 12, 2024

@avivko would you be able to check this out & confirm it resolves your issue?

Copy link

sonarcloud bot commented Mar 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.68%. Comparing base (8123f42) to head (08c9c04).
Report is 165 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   40.27%   44.68%   +4.41%     
==========================================
  Files          48      113      +65     
  Lines        2811     7908    +5097     
==========================================
+ Hits         1132     3534    +2402     
- Misses       1679     4374    +2695     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-r-j a-r-j merged commit 79b21a5 into master Mar 31, 2024
31 of 34 checks passed
@a-r-j a-r-j deleted the docker_nb_fix branch July 15, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants